SO-5901: support description languages in generic concept model #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...description's language code and refsetId combinations to represent all possible terms.
...specifying the language part as well
...languagecode + language refset combination so that clients can select the most appropriate one when looking up concept's with their designations.
Concept.alternativeTerms is now deprecated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1275 +/- ##
=========================================
Coverage 48.21% 48.21%
- Complexity 13923 13931 +8
=========================================
Files 1946 1947 +1
Lines 95122 95149 +27
Branches 10985 10985
=========================================
+ Hits 45860 45877 +17
- Misses 46269 46278 +9
- Partials 2993 2994 +1 ☔ View full report in Codecov by Sentry. |
AAAlinaaa
approved these changes
Apr 9, 2024
...src/com/b2international/snowowl/snomed/core/request/SnomedConceptSearchRequestEvaluator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generic descriptions instead of a List of Strings on the generic Concept model.
The primary use for this is going to be FHIR endpoints where additional (even on the fly generated) designations need to be sent back in the response along with the concept's display.
In case of SNOMED CT Snow Owl now follows the latest spec version which requires designations to be returned for each languageCode + language reference set id combination.