Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snomed.reasoner): Reinstate equivalent concept merging extension #1277

Merged
merged 4 commits into from
May 17, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Apr 8, 2024

No description provided.

@apeteri apeteri requested review from cmark and nagyo April 8, 2024 16:26
@apeteri apeteri self-assigned this Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 48.46%. Comparing base (bd29612) to head (4d2dc94).

Current head 4d2dc94 differs from pull request most recent head ba1b564

Please upload reports for the commit ba1b564 to get more accurate results.

Files Patch % Lines
...nowowl/snomed/reasoner/request/SaveJobRequest.java 0.00% 4 Missing ⚠️
...reasoner/equivalence/IEquivalentConceptMerger.java 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1277   +/-   ##
=========================================
  Coverage     48.45%   48.46%           
  Complexity    14000    14000           
=========================================
  Files          1947     1947           
  Lines         95170    95177    +7     
  Branches      11001    11000    -1     
=========================================
+ Hits          46113    46124   +11     
+ Misses        46037    46034    -3     
+ Partials       3020     3019    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apeteri apeteri force-pushed the feature/equivalent-concept-merger branch from 7d95eb3 to cfef3f5 Compare April 18, 2024 10:00
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@apeteri apeteri force-pushed the feature/equivalent-concept-merger branch from cfef3f5 to 44d7db6 Compare April 30, 2024 09:36
...implementations into components, introduce registry
@apeteri apeteri force-pushed the feature/equivalent-concept-merger branch from 44d7db6 to 4d2dc94 Compare May 17, 2024 08:06
apeteri and others added 3 commits May 17, 2024 10:35
...type refset members in SnomedRefSetMemberSearchRequest
…gration

Small improvements to 9.x related to the event bus and field replacement
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit cc1a906 into 9.x May 17, 2024
2 checks passed
@cmark cmark deleted the feature/equivalent-concept-merger branch May 17, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants