Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowowl.core): Small change required for downstream project #1294

Merged
merged 5 commits into from
May 14, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented May 14, 2024

  • Make test dependencies of com.b2international.snowowl.validation.snomed optional so that they do not need to be included in launch configurations
  • Make the RF2 importer for relationships less strict, allowing matching sourceId and destinationId values for non-IS A relationships
  • Add Java system property that allows extending the list of Java packages to inspect during classpath scanning (the property name is so.component.scan and it expects a comma-separated list of package names as its value)

@apeteri apeteri requested review from cmark and nagyo May 14, 2024 08:48
@apeteri apeteri self-assigned this May 14, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.34%. Comparing base (5d787b2) to head (039b1c7).
Report is 2 commits behind head on 9.x.

Files Patch % Lines
.../src/com/b2international/snowowl/core/SnowOwl.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1294      +/-   ##
============================================
- Coverage     48.35%   48.34%   -0.01%     
- Complexity    13976    13978       +2     
============================================
  Files          1947     1947              
  Lines         95154    95163       +9     
  Branches      10997    10999       +2     
============================================
+ Hits          46007    46010       +3     
- Misses        46134    46139       +5     
- Partials       3013     3014       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit ac87f06 into 9.x May 14, 2024
5 checks passed
@cmark cmark deleted the feature/SO-6022-tooling-improvements branch May 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants