Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6121: propagate namespaceConceptId when creating descriptions/relationships via concept create API #1295

Merged
merged 1 commit into from
May 14, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented May 14, 2024

No description provided.

...and relationships inside a concept request
@cmark cmark added the bug label May 14, 2024
@cmark cmark requested review from apeteri and nagyo May 14, 2024 09:25
@cmark cmark self-assigned this May 14, 2024
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 48.36%. Comparing base (5d787b2) to head (52c1e4c).

Files Patch % Lines
...nomed/core/rest/domain/SnomedConceptRestInput.java 66.66% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1295      +/-   ##
============================================
+ Coverage     48.35%   48.36%   +0.01%     
- Complexity    13976    13986      +10     
============================================
  Files          1947     1947              
  Lines         95154    95158       +4     
  Branches      10997    10999       +2     
============================================
+ Hits          46007    46027      +20     
+ Misses        46134    46117      -17     
- Partials       3013     3014       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit bf9f5e6 into 9.x May 14, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6121-missing-namespaceConceptId-propagation branch May 14, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants