Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6100: remove unnecessary SHA1 conversion of jobId in RF2 import API #1296

Merged
merged 1 commit into from
May 14, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented May 14, 2024

No description provided.

@cmark cmark added the bug label May 14, 2024
@cmark cmark requested review from apeteri and nagyo May 14, 2024 10:07
@cmark cmark self-assigned this May 14, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.36%. Comparing base (bf9f5e6) to head (2ac464b).
Report is 6 commits behind head on 9.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1296   +/-   ##
=========================================
  Coverage     48.36%   48.36%           
- Complexity    13985    13986    +1     
=========================================
  Files          1947     1947           
  Lines         95158    95158           
  Branches      10999    10999           
=========================================
+ Hits          46023    46025    +2     
+ Misses        46120    46118    -2     
  Partials       3015     3015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 9e52ed8 into 9.x May 14, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6100-import-id-inconsistency branch May 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants