Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): transaction referential integrity check improvements #1303

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented Jun 26, 2024

NOTE: test cases will arrive later in a separate PR.

...consider the current tx content as well when committing a set of
changes.
...to allow bulk requests with random request order to be committed
without raising component not found errors.
...when converting a SnomedReferenceSetMember to a create request
without a containerId.
@cmark cmark requested review from apeteri and nagyo June 26, 2024 10:53
@cmark cmark self-assigned this Jun 26, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.49%. Comparing base (f049071) to head (44f27fe).

Files Patch % Lines
.../core/repository/RepositoryTransactionContext.java 68.42% 3 Missing and 3 partials ⚠️
...d/core/domain/refset/SnomedReferenceSetMember.java 0.00% 0 Missing and 1 partial ⚠️
...l/snomed/core/store/SnomedRelationshipBuilder.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1303      +/-   ##
============================================
+ Coverage     48.47%   48.49%   +0.01%     
- Complexity    14027    14035       +8     
============================================
  Files          1948     1948              
  Lines         95292    95313      +21     
  Branches      11011    11014       +3     
============================================
+ Hits          46194    46220      +26     
+ Misses        46063    46055       -8     
- Partials       3035     3038       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit db7ecdb into 9.x Jun 26, 2024
5 checks passed
@cmark cmark deleted the issue/consider-tx-during-referential-integrity-check branch June 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants