SO-5868: Retrieve validation results via REST #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1310 +/- ##
============================================
+ Coverage 48.46% 48.57% +0.10%
- Complexity 14037 14071 +34
============================================
Files 1949 1949
Lines 95376 95379 +3
Branches 11024 11024
============================================
+ Hits 46228 46329 +101
+ Misses 46108 46018 -90
+ Partials 3040 3032 -8 ☔ View full report in Codecov by Sentry. |
cmark
requested changes
Aug 12, 2024
| @@ -181,6 +181,16 @@ public SnowOwlOpenApiWebMvcResource openApiWebMvcResource( | |||
| @Bean | |||
| @Scope(scopeName = WebApplicationContext.SCOPE_REQUEST, proxyMode = ScopedProxyMode.TARGET_CLASS) | |||
| public ObjectMapper objectMapper(@Autowired HttpServletRequest request) { | |||
| return objectMapperFromRequest(request); | |||
There was a problem hiding this comment.
I think for consistency, this should be a provider as well.
There was a problem hiding this comment.
As I see it, we are going to need the two different methods:
This method with ObjectMapper return type is necessary for mappingJackson2HttpMessageConverter()
And the other one, with Provider is necessary for the RepositoryValidationRestService class
There was a problem hiding this comment.
IIRC we tried three approaches:
- Keep the initialization code in this method and refer to it in the provider lambda
- → the
ProviderproducedObjectMapperdelegates (proxies) that expected a request scope to be present, triggering the exception in the validation REST controller (where it was originally reported)
- → the
- Move the initialization code to the lambda and create an instance here using the
Provider- → the returned instance is an actual
ObjectMapperbut creating it requires a request scope which is not available at startup, triggering the exception right away
- → the returned instance is an actual
- Move the initialization code to a non-@
Bean-annotated method and refer to it from both annotated methods- → the current state of the PR that worked without issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.