Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snomed.datastore): Allow clients to selectively update concept members #1311

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Aug 6, 2024

This is intended for users of the Java API who are not able to present a complete list of members (that includes both members to be updated as well as the ones which need to stay as they are) in SnomedConceptUpdateRequest's reference set members collection.

...in SnomedConceptUpdateRequest. This allows callers to treat existing
members of certain reference set types as if they were not present on
the concept at all.
@apeteri apeteri self-assigned this Aug 6, 2024
@apeteri apeteri requested review from nagyo and AAAlinaaa August 6, 2024 16:27
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (e32a661) to head (4abce5d).

Files Patch % Lines
...onal/snowowl/snomed/core/domain/SnomedConcept.java 0.00% 17 Missing ⚠️
.../datastore/request/SnomedConceptUpdateRequest.java 60.00% 1 Missing and 1 partial ⚠️
...ore/request/SnomedConceptUpdateRequestBuilder.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1311   +/-   ##
=========================================
  Coverage     48.46%   48.46%           
- Complexity    14035    14036    +1     
=========================================
  Files          1949     1949           
  Lines         95369    95377    +8     
  Branches      11024    11024           
=========================================
+ Hits          46223    46227    +4     
- Misses        46111    46114    +3     
- Partials       3035     3036    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apeteri apeteri merged commit ca83c6e into 9.x Aug 8, 2024
4 of 5 checks passed
@apeteri apeteri deleted the feature/SO-6224-concept-member-updates branch August 8, 2024 10:59
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants