SO-2178-job-api #132

cmark · 2017-03-03T11:18:41Z

Introduce request based job API.
The implementation allows any Request to be wrapped into a job to monitor its execution.

Major changes:

Added a single EventBus instance to the global ApplicationContext to handle all incoming requests (Remote Jobs are still managed by the Eclipse Job API under the hood)
Removed repository specific IEventBus handlers
Support java.util.Date types in document mapping
Introduced RxJava based Notification observable for all system level notifications
Request interface is now a FunctionalInterface (automatically detects the return type based on the generic type parameters)
Flatten RequestBuilder hierarchy (classes/methods that supported asynchronous request wrapping are now extracted to interfaces with default methods)

Minor changes/fixes:

DelegatingServiceProvider now disposes all locally registered services during server shutdown
ReviewManager is now an IDisposableService

Remove repository specific notification and request bus addresses. Introduce new global /notifications and /requests bus addresses. Introduce global ObjectMapper instance.

Add CANCELLED end state to RemoteJobState. Convert RemoteJobEntry to immutable object.

Rename RemoteJobStore to RemoteJobTracker. Add deleted flag to RemoteJobEntry. Search returns only not deleted jobs. Use search API in GetJobRequest.

...marked for deletion

...to track progress of remote jobs

Make Request a functional interface. Resolve return type information reflectively using typetools library.

Remove BaseRequest abstract base class reference. Remove getReturnType implementations.

Conflicts: core/com.b2international.snowowl.datastore.server/src/com/b2international/snowowl/datastore/server/internal/merge/BranchMergeJob.java core/com.b2international.snowowl.datastore.server/src/com/b2international/snowowl/datastore/server/internal/merge/BranchRebaseJob.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetCreateRequest.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberCreateRequest.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberUpdateRequest.java

...exists for them to extract information from.

...if the corresponding reference set is removed, leaving the identifier concept behind.

...methods in SnomedEditingContext#delete(EObject, boolean)

...via Repository.notifications()

...instead of custom event bus handler

...JsonIgnore annotations to the lock context description and additional concept definitions properties; change branch path to a String

Conflicts: core/com.b2international.snowowl.core/src/com/b2international/snowowl/core/events/BaseRequest.java core/com.b2international.snowowl.datastore/src/com/b2international/snowowl/datastore/request/BaseResourceRequestBuilder.java core/com.b2international.snowowl.datastore/src/com/b2international/snowowl/datastore/request/RevisionSearchRequestBuilder.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedRequests.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedSearchRequestBuilder.java

Remove branching/merging/reviews API access methods from SnomedRequests. They are available via RepositoryRequests.

This reverts commit 80b8ea3.

...in SnomedClassificationServiceImpl

apeteri

Consider making ApiError a generic status response. Looks good otherwise!

cmark · 2017-03-03T14:59:00Z

👍

cmark added 30 commits February 20, 2017 17:48

SO-2178: refactor repository request support

6f14ba9

Remove repository specific notification and request bus addresses. Introduce new global /notifications and /requests bus addresses. Introduce global ObjectMapper instance.

SO-2178: initial version of request based remote job API (WIP)

31e6d87

SO-2178: remove unused API method

49c75b7

SO-2178: support Date fieldTypes in document mapping

c9ac014

SO-2178: implement job schedule, delete, cancel, get use cases

84911c9

Add CANCELLED end state to RemoteJobState. Convert RemoteJobEntry to immutable object.

SO-2178: refactor job deletion logic

9e79f02

Rename RemoteJobStore to RemoteJobTracker. Add deleted flag to RemoteJobEntry. Search returns only not deleted jobs. Use search API in GetJobRequest.

SO-2178: assert that remote job tracker eventually deletes entries...

f12a7c4

...marked for deletion

SO-2178: support deletion of multiple jobs at once

873441a

SO-2178: remove unused/old API classes

83b0ac5

SO-2178: use custom progress monitor from RemoteJobTracker...

d9a8828

...to track progress of remote jobs

SO-2178: add SearchJobRequestBuilder and filter options

320488f

SO-2178: convert nested cond.operator to if-else block

48cca71

SO-2178: track progress of RemoteJobs via monitor

49950e2

SO-2178: accept async request in ScheduleJobRequestBuilder

6b87cb5

SO-2178: send remote job added/changed/removed notifications

9813503

SO-2178: set request as a parameters object in RemoteJobEntry

cc63347

SO-2178: removed unnecessary remote job services and xml entries

55c793a

SO-2178: support async execution of job requests

5788f2b

SO-2178: add typetools to commons bundle

d28fef4

SO-2178: pull up BaseRequest declarations to Request

871d036

Make Request a functional interface. Resolve return type information reflectively using typetools library.

SO-2178: migrate implementations of Request interface

15a86d8

Remove BaseRequest abstract base class reference. Remove getReturnType implementations.

SO-2178: catch any Throwable when trying to serialize the request

edb7380

SO-2178: remove unused ClassUtils.getTypeParameter() methods

34c1c1f

SO-2178: move CDOServerCommitBuilder to datastore module

e9c5365

SO-2178: remove unused code system bean implementations

fe603c8

SO-2178: move terminology registry model to datastore bundle

262fbd2

SO-2178: remove terminologyregistry.model bundle

cca519a

SO-2178: move CodeSystem request API to datastore bundle

ffcb7ec

SO-2178: remove terminologyregistry.core bundle

7a57493

apeteri and others added 17 commits March 2, 2017 16:11

SO-2178 Check if the return type parameter could be resolved to a class

710149d

SO-2178 Rename type variable in ResourceRequest

85acc59

SO-2178 Pass return type to GetResourceRequests as no typed subclass...

23c1de9

...exists for them to extract information from.

SO-2178 Introduce SNOMED CT-specific delete request builder

29dfe34

SO-2178 Validate the "core" request in commit request builders

230b21d

SO-2178 Add JsonIgnore annotation to CollectionResource; rename property

fbe7ea4

SO-2178 Replace prefixMatch expression in SnomedRefSetSearchRequest

06c104e

SO-2178 Fix classification test cases (to be revised later)

a214900

SO-2178 Clear refSetType field as well from SnomedConceptDocument...

6b30f22

...if the corresponding reference set is removed, leaving the identifier concept behind.

SO-2178 Don't try to remove the same component twice with different...

47f7648

...methods in SnomedEditingContext#delete(EObject, boolean)

SO-2178: support repository specific notification stream...

c304609

...via Repository.notifications()

SO-2178: use repository specific notification stream in ReviewManager...

9ed29bc

...instead of custom event bus handler

SO-2178: dispose services in a repo when disposing it

a7008aa

SO-2178: fix it-test launch configurations

f490bb6

SO-2178 Remove userId field from ClassificationSettings; add...

80b8ea3

...JsonIgnore annotations to the lock context description and additional concept definitions properties; change branch path to a String

SO-2178: convert syserrs to trace level log messages

f2120c2

SO-2178: add back repository locking to version create request

9a93667

cmark assigned cmark and apeteri Mar 3, 2017

cmark and others added 6 commits March 3, 2017 14:41

[javadoc] migrate javadoc to new 5.7 API in SnomedRequests

053354b

Remove branching/merging/reviews API access methods from SnomedRequests. They are available via RepositoryRequests.

SO-2178 Allow setting a remote job's identifier externally

c3a9d3c

SO-2178 Change spelling of "canceled" remote job state

7578375

Revert "SO-2178 Remove userId field from ClassificationSettings; add..."

348184b

This reverts commit 80b8ea3.

SO-2178 Use ApiError instead of IStatus, rxJava-based notifications...

75ccbfb

...in SnomedClassificationServiceImpl

cmark requested a review from apeteri March 3, 2017 14:52

apeteri approved these changes Mar 3, 2017

View reviewed changes

cmark merged commit e0df6bc into develop Mar 3, 2017

cmark deleted the feature/SO-2178-job-api branch April 5, 2017 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SO-2178-job-api #132

SO-2178-job-api #132

cmark commented Mar 3, 2017 •

edited

Loading

apeteri left a comment

cmark commented Mar 3, 2017

SO-2178-job-api #132

SO-2178-job-api #132

Conversation

cmark commented Mar 3, 2017 • edited Loading

apeteri left a comment

Choose a reason for hiding this comment

cmark commented Mar 3, 2017

cmark commented Mar 3, 2017 •

edited

Loading