Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6267: Update handling of validation thread pool size #1320

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Sep 13, 2024

  • Change the property name from numberOfValidationThreads to workerPoolSize
  • Allow setting either property for backwards compatibility (setting both results in undefined behavior)
  • Use null as the default value
  • Increase allowed maximum pool size to 99
  • Compute a reasonable default value on the server side if the value remains unset in Snow Owl's configuration file

...worker pool size; compute a reasonable value on the server if the
setting is left empty.
@apeteri apeteri requested review from cmark and nagyo September 13, 2024 13:09
@apeteri apeteri self-assigned this Sep 13, 2024
int numberOfValidationThreads = validationConfig.getNumberOfValidationThreads();
Integer workerPoolSize = validationConfig.getWorkerPoolSize();
if (workerPoolSize == null) {
// Restrict thread pool size to the [4..12] range (both inclusive)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.57%. Comparing base (c0d0904) to head (bb2a754).
Report is 286 commits behind head on 9.x.

Files with missing lines Patch % Lines
...e/internal/validation/ValidationConfiguration.java 25.00% 3 Missing ⚠️
...owl/core/internal/validation/ValidationPlugin.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1320      +/-   ##
============================================
- Coverage     48.57%   48.57%   -0.01%     
+ Complexity    14074    14071       -3     
============================================
  Files          1949     1949              
  Lines         95379    95380       +1     
  Branches      11024    11025       +1     
============================================
- Hits          46334    46329       -5     
- Misses        46016    46018       +2     
- Partials       3029     3033       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit 72bf94f into 9.x Sep 13, 2024
5 checks passed
@cmark cmark deleted the feature/SO-6267-validation-worker-pool-config branch September 13, 2024 13:42
@nagyo nagyo added the port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants