-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-6267: Update handling of validation thread pool size #1320
Conversation
...worker pool size; compute a reasonable value on the server if the setting is left empty.
int numberOfValidationThreads = validationConfig.getNumberOfValidationThreads(); | ||
Integer workerPoolSize = validationConfig.getWorkerPoolSize(); | ||
if (workerPoolSize == null) { | ||
// Restrict thread pool size to the [4..12] range (both inclusive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1320 +/- ##
============================================
- Coverage 48.57% 48.57% -0.01%
+ Complexity 14074 14071 -3
============================================
Files 1949 1949
Lines 95379 95380 +1
Branches 11024 11025 +1
============================================
- Hits 46334 46329 -5
- Misses 46016 46018 +2
- Partials 3029 3033 +4 ☔ View full report in Codecov by Sentry. |
numberOfValidationThreads
toworkerPoolSize
null
as the default value