Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MRCM type expressions configurable #1325

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

AAAlinaaa
Copy link
Contributor

No description provided.

@AAAlinaaa AAAlinaaa self-assigned this Sep 23, 2024
public class SnomedMrcmConfig {

private String allowedDataAttributesExpression = "<" + Concepts.CONCEPT_MODEL_DATA_ATTRIBUTE;
private String allowedObjectAttributesExpression = "<" + Concepts.CONCEPT_MODEL_OBJECT_ATTRIBUTE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗒️ Mental note: 408739003 |Unapproved attribute| is a frequently used object attribute root as well

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.58%. Comparing base (9240139) to head (c6b6e76).
Report is 2 commits behind head on 9.x.

Files with missing lines Patch % Lines
...wowl/snomed/datastore/config/SnomedMrcmConfig.java 55.55% 4 Missing ⚠️
...omed/datastore/config/SnomedCoreConfiguration.java 50.00% 2 Missing ⚠️
...nomed/datastore/request/SnomedMrcmTypeRequest.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1325   +/-   ##
=========================================
  Coverage     48.57%   48.58%           
- Complexity    14069    14074    +5     
=========================================
  Files          1949     1950    +1     
  Lines         95406    95425   +19     
  Branches      11026    11026           
=========================================
+ Hits          46345    46358   +13     
- Misses        46026    46033    +7     
+ Partials       3035     3034    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit 5e46c5d into 9.x Sep 24, 2024
5 checks passed
@cmark cmark deleted the issue/mrcm-attribute-type-configurations branch September 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants