Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support versioning derived resources #1327

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Sep 25, 2024

No description provided.

@apeteri apeteri requested a review from cmark September 25, 2024 11:37
@apeteri apeteri self-assigned this Sep 25, 2024
.map(uri -> uri.getResourceId())
.collect(Collectors.toSet());

ResourceRequests.prepareSearch()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The execution of this request can be skipped if there is no derivativeId present in the above set.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 48.57%. Comparing base (5e46c5d) to head (c0e4c75).
Report is 4 commits behind head on 9.x.

Files with missing lines Patch % Lines
...owl/core/request/version/VersionCreateRequest.java 39.13% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1327      +/-   ##
============================================
- Coverage     48.57%   48.57%   -0.01%     
- Complexity    14075    14078       +3     
============================================
  Files          1950     1950              
  Lines         95425    95448      +23     
  Branches      11026    11027       +1     
============================================
+ Hits          46357    46368      +11     
- Misses        46035    46046      +11     
- Partials       3033     3034       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark requested a review from nagyo September 25, 2024 12:36
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 6b8737a into 9.x Sep 25, 2024
3 of 5 checks passed
@cmark cmark deleted the feature/SO-6287-version-derived-resources branch September 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants