Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6081: support multiple FHIR versions in the REST API #1332

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented Oct 7, 2024

This PR adds support for multiple FHIR mime types, supporting R4, R4B, and R5.
This PR also adds a new operation CapabilityStatement$versions to list the available versions in Snow Owl.

@cmark cmark requested a review from apeteri October 7, 2024 20:59
@cmark cmark self-assigned this Oct 7, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 160 lines in your changes missing coverage. Please review.

Project coverage is 63.63%. Comparing base (8e1a9ea) to head (2a09f67).
Report is 15 commits behind head on 9.x.

Files with missing lines Patch % Lines
...international/snowowl/fhir/rest/FhirMediaType.java 44.56% 91 Missing and 11 partials ⚠️
...onal/snowowl/fhir/rest/AbstractFhirController.java 48.64% 18 Missing and 1 partial ⚠️
...ir/rest/FhirValueSetExpandOperationController.java 12.50% 2 Missing and 12 partials ⚠️
...wl/fhir/rest/FhirCodeSystemSubsumesController.java 14.28% 6 Missing ⚠️
...l/fhir/rest/FhirConceptMapTranslateController.java 0.00% 6 Missing ⚠️
.../fhir/rest/FhirValueSetValidateCodeController.java 0.00% 6 Missing ⚠️
...owl/fhir/rest/FhirVersionsOperationController.java 14.28% 6 Missing ⚠️
...hir/rest/FhirCodeSystemValidateCodeController.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1332      +/-   ##
============================================
- Coverage     63.68%   63.63%   -0.06%     
- Complexity    12471    12486      +15     
============================================
  Files          1609     1611       +2     
  Lines         56809    56955     +146     
  Branches       5595     5598       +3     
============================================
+ Hits          36180    36244      +64     
- Misses        18295    18375      +80     
- Partials       2334     2336       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark marked this pull request as ready for review October 9, 2024 16:46
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍃

@cmark cmark merged commit e3c94a9 into 9.x Oct 10, 2024
2 checks passed
@cmark cmark deleted the feature/SO-6081-versioned-mime-types branch October 10, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants