Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#284 Add a copy mind map button #285

Merged

Conversation

sorenjohanson
Copy link
Collaborator

@sorenjohanson sorenjohanson commented Jun 15, 2024

closes #284

@JannikStreek
Copy link
Member

JannikStreek commented Jun 16, 2024

thanks, already looking good 👍

UX:

  • Maybe we can add a small info note popup that says "Successfully cloned" ? Otherwise the user might think nothing happened - as the map looks the same. Only thing I could found is the Dialog in material ui.

PR:

  • Please Add a "closes #ISSUE_NUMBER_HERE" in the description

Test:

  • Maybe add one controller test, only for this method? we can add other controller tests in a separate PR.

@sorenjohanson
Copy link
Collaborator Author

UX:

  • Maybe we can add a small info note popup that says "Successfully cloned" ? Otherwise the user might think nothing happened - as the map looks the same. Only thing I could found is the Dialog in material ui.

Do we already have something similar for other use cases? Could integrate ngx-toastr otherwise, but I don't know if that's maybe a bit overkill.

@JannikStreek
Copy link
Member

UX:

  • Maybe we can add a small info note popup that says "Successfully cloned" ? Otherwise the user might think nothing happened - as the map looks the same. Only thing I could found is the Dialog in material ui.

Do we already have something similar for other use cases? Could integrate ngx-toastr otherwise, but I don't know if that's maybe a bit overkill.

only material dialogs which are also quite heavy for just displaying a simply message. otherwise we could also just code/style or own, not sure if a library is suited just for small alerts.

sorenjohanson added 3 commits June 17, 2024 09:01
@JannikStreek JannikStreek merged commit 8afce5c into b310-digital:main Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a copy mind map button
2 participants