-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internalize componentparameter #1111
Conversation
161d9c5
to
bed96a2
Compare
For sure the documentation and samples have to be updated. |
f91e789
to
145e708
Compare
Thanks for the input. I'll be back with new changes. |
62e1c64
to
ff2f95d
Compare
Back on a plane, thus I finally have time to finish this. Docs should be up to date now. |
refactor: public methods
fcc9d30
to
880570e
Compare
The sample solution is not compilable. |
That should be fixed now. |
Right now every test in |
Honestly was a bit lazy here. The problem is that the code snippets in the docs are referenced by line numbers meaning I would need to go and update all the line offsets, and that a fairly big task 😅 |
I don't think that file is used. See here: https://grep.app/search?q=AllKindsOfParamsTest&case=true&filter[lang][0]=C%23 So maybe just delete the thing completely. EDIT: The Passing parameters to components section is using different components for its content. So that file seems either for super advanced users that might check the repository and discover this - or it's obsolete. I am leaning towards the second opinion. So delete the file entirely |
407006f
to
a9dc0d2
Compare
You are right, thanks for keeping me honest :) Lets get this merged, unless you spot other things? |
Closes #1017
Merge after #1110, forgot to split the branches on the plane :)