Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing opening tag #775

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: Added missing opening tag #775

merged 1 commit into from
Jun 27, 2022

Conversation

linkdotnet
Copy link
Collaborator

While I was running through the docs I saw some super small issues.
Basically the opening tag of the <div> was missing which would result in a compilation error for the user if he just copy pastes that thing.

@linkdotnet linkdotnet requested a review from egil June 27, 2022 17:05
Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@egil
Copy link
Member

egil commented Jun 27, 2022

@linkdotnet feel free to rebase/merge in when all checks pass. If you cannot, let me know, ill look at the security settings.

In general, if I dont want to you to complete the PR, I wont approve or at least tell you to hold off on it.

@linkdotnet
Copy link
Collaborator Author

The base branch restricts merging to authorized users.

Can't merge to stable :D

@egil egil merged commit 9a81bc9 into stable Jun 27, 2022
@egil egil deleted the bugfix/invalid-example branch June 27, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants