Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to configure retry options for Consul discovery client #51

Conversation

gcotelli
Copy link
Member

ConsulAgentHttpAPIBasedDiscoveryClient

Fixes #46

@gcotelli gcotelli added this to the v3.0.0 milestone Nov 29, 2021
@gcotelli gcotelli self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #51 (b02e031) into release-candidate (1740576) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-candidate      #51   +/-   ##
==================================================
  Coverage              99.62%   99.63%           
==================================================
  Files                     53       53           
  Lines                   2960     2992   +32     
==================================================
+ Hits                    2949     2981   +32     
  Misses                    11       11           
Impacted Files Coverage Δ
...mples/SuperluminalServiceDiscoveryExample.class.st 100.00% <100.00%> (ø)
...ry/ConsulAgentHttpAPIBasedDiscoveryClient.class.st 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1740576...b02e031. Read the comment docs.

@gcotelli gcotelli merged commit 65b7d10 into release-candidate Nov 29, 2021
@gcotelli gcotelli deleted the 46-Option-to-wait-between-retries-in-ConsulAgentHttpAPIBasedDiscoveryClient branch November 29, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to wait between retries in ConsulAgentHttpAPIBasedDiscoveryClient
2 participants