Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #52

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Update documentation #52

merged 6 commits into from
Dec 1, 2021

Conversation

gcotelli
Copy link
Member

@gcotelli gcotelli commented Dec 1, 2021

Fixed #32

@gcotelli gcotelli added this to the v3.0.0 milestone Dec 1, 2021
@gcotelli gcotelli self-assigned this Dec 1, 2021
github-actions[bot]
github-actions bot reviewed Dec 1, 2021
View reviewed changes
docs/reference/API-Client.md Outdated Show resolved Hide resolved
docs/reference/HTTP-Request.md Outdated Show resolved Hide resolved
docs/reference/HTTP-Request.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #52 (c82f0eb) into release-candidate (65b7d10) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c82f0eb differs from pull request most recent head fb83bd1. Consider uploading reports for the commit fb83bd1 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           release-candidate      #52   +/-   ##
==================================================
  Coverage              99.63%   99.63%           
==================================================
  Files                     53       53           
  Lines                   2992     2997    +5     
==================================================
+ Hits                    2981     2986    +5     
  Misses                    11       11
Impacted Files Coverage Δ
.../Superluminal-RESTfulAPI/RESTfulAPIClient.class.st 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b7d10...fb83bd1. Read the comment docs.

mtabacman
mtabacman requested changes Dec 1, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/how-to/how-to-use-as-dependency-in-pharo.md Outdated Show resolved Hide resolved
docs/how-to/how-to-use-as-dependency-in-pharo.md Outdated Show resolved Hide resolved
docs/reference/API-Client.md Outdated Show resolved Hide resolved
docs/reference/API-Client.md Outdated Show resolved Hide resolved
docs/reference/Baseline-groups.md Outdated Show resolved Hide resolved
docs/reference/Service-Discovery.md Outdated Show resolved Hide resolved
docs/reference/Service-Discovery.md Outdated Show resolved Hide resolved
docs/reference/Service-Discovery.md Outdated Show resolved Hide resolved
docs/reference/Service-Discovery.md Outdated Show resolved Hide resolved
@gcotelli @mtabacman
Apply suggestions from code review
fb83bd1 
Co-authored-by: Maximiliano Tabacman <mtabacman@users.noreply.github.com>
mtabacman
mtabacman previously approved these changes Dec 1, 2021
View reviewed changes
@gcotelli gcotelli merged commit 8537a4e into release-candidate Dec 1, 2021
@gcotelli gcotelli deleted the docs branch December 1, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mtabacman mtabacman mtabacman left review comments

@fortizpenaloza fortizpenaloza Awaiting requested review from fortizpenaloza

Assignees

@gcotelli gcotelli

Labels
Type: Improvement
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Add a quick start guide
2 participants
@gcotelli @mtabacman