Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DNU when using an API client with a relative URL #54

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

gcotelli
Copy link
Member

No description provided.

@gcotelli gcotelli requested review from jvanecek and serpi90 June 16, 2022 18:22
@gcotelli gcotelli self-assigned this Jun 16, 2022
fortizpenaloza
fortizpenaloza previously approved these changes Jun 16, 2022
jvanecek
jvanecek previously approved these changes Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #54 (733fc9f) into release-candidate (7f64b21) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           release-candidate      #54      +/-   ##
=====================================================
- Coverage              99.63%   99.63%   -0.01%     
=====================================================
  Files                     53       53              
  Lines                   2999     2997       -2     
=====================================================
- Hits                    2988     2986       -2     
  Misses                    11       11              
Impacted Files Coverage Δ
...del-Tests/CompositeHttpRequestCommandTest.class.st 100.00% <100.00%> (ø)
...API-Tests/RESTfulAPIClientIntegrationTest.class.st 100.00% <100.00%> (ø)
...nal-RESTfulAPI-Tests/RESTfulAPIClientTest.class.st 100.00% <100.00%> (ø)
.../Superluminal-RESTfulAPI/RESTfulAPIClient.class.st 100.00% <100.00%> (ø)
...onsulAgentHttpAPIBasedDiscoveryClientTest.class.st 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f64b21...733fc9f. Read the comment docs.

@gcotelli gcotelli dismissed stale reviews from jvanecek and fortizpenaloza via 733fc9f June 16, 2022 18:36
@gcotelli gcotelli merged commit a11caa6 into release-candidate Jun 16, 2022
@gcotelli gcotelli deleted the use_asAbsoluteUrl branch June 16, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants