-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update googletest version to 1.11.0 #35
Conversation
existing submodule googletest v1.8.x caused cmake deprecation warning, I updated googletest version to 1.11.0
@emiatej9 Centos5를 테스트에 넣은건 오래된 레거시 환경에서도 작동이 잘되도록 보장하고 싶었기 때문인데요, gtest 최신 버전이 발목을 잡는 문제가 있군요. 어떻게 해결하는게 좋을지 좀 고민해봐야할거 같아요~
|
그렇다면 CentOS 5에서는 빌드에서 사용하는 cmake 버전과 googletest 버전을 둘 다 낮춰서 테스트를 구성하는 방법이 있을까요? 제가 git workflow 는 잘 몰라서 감이 없네요. 만약 CentOS 5만 cmake 버전과 googletest 버전을 낮춰서 구성할 수 있다면, 이들 (구)버전까지 커버할 수 있도록 CMakeLists.txt 파일이나 googletest 관련 부분이 분기를 나누어주어야 할 수도 있겠네요. |
@emiatej9 Kiwi/.github/workflows/centos5.yml Lines 14 to 23 in 0996518
Kiwi/.github/workflows/release.yml Lines 14 to 21 in 0996518
요 두 부분이 Centos5관련 workflow인데 Configure Build 전에 step을 하나 추가해서 googletest 레포를 |
네, 수정해서 커밋 해보겠습니다. |
googletest v1.11.0 does not support pre-C++11, which causes build fail on manylinux1 environment(CentOS 5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘해주셨는데요 마지막에 cd가 빠졌네요. 해당부분만 수정해주시면 문제없이 빌드될거 같습니다!
omitted 'cd' command in checking out googletest version v1.11.0.
googletest v1.11.0 does not support pre-C++11, which causes build fail on manylinux1 environment(CentOS 5).
googletest v1.11.0 does not support pre-C++11, which causes build fail on manylinux1 environment(CentOS 5). therefore, googletest should be checked out v1.8.x before starting build process on manylinux1 environment.
@emiatej9 |
update googletest version to 1.11.0 Former-commit-id: 844474e
update googletest version to 1.11.0 Former-commit-id: 844474e
fixed #34
existing submodule googletest v1.8.x caused cmake deprecation warning,
I updated googletest version to 1.11.0.