Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added scoop config #54

Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat: added scoop config #54

merged 2 commits into from
Feb 11, 2025

Conversation

Souvlaki42
Copy link
Contributor

Added scoop publishing to .goleaser.yaml according to goreleaser's docs. Change it to your own details. I was not allowed to test it in my fork, so please do it.
Addresses: #53

.goreleaser.yaml Outdated Show resolved Hide resolved
@Souvlaki42
Copy link
Contributor Author

Souvlaki42 commented Feb 10, 2025

@babarot I think I succeeded at fixing the issues. I put your details on .goreleaser.yaml. It turns out I didn't need your email, as the commit related configs were optional. I also installed the goreleaser CLI, fixed some deprecation warnings with the format fields which has no impact on the app, I just happened to notice them when running goreleaser check again your config file. I merged some pull request in my fork, you also had, in fork. I don't know if you wanted to. After running a local-only build using goreleaser release --snapshot --clean I noticed that a scoop manifest was generated successfully, but I don't know how to get the app published or if I can do it on your behalf, so here is once again some relevant docs for you, if that helps: scoop docs - goreleaser. I also want to ask if you are currently using Goreleaser Pro as this might affect how much I can help you with the process. I don't know any projects using Go and goreleaser to publish to scoop to reference. The closest I have is projects like lazygit and lazydocker. I'm sorry in advance for any inconvenience I might have caused.

CHANGELOG.md Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@Souvlaki42
Copy link
Contributor Author

@babarot Look, I'm sorry if I made you upset. I'm trying to help. I synced our branches discarding anything I accidentally changed and just committed the changes to .goreleaser.yml I initially wanted. Take a look now and if everything is broken again, I'll stop bothering you.

@Souvlaki42 Souvlaki42 reopened this Feb 11, 2025
@babarot
Copy link
Owner

babarot commented Feb 11, 2025

Thanks for your support! @Souvlaki42

I appreciate your contribution. I was a bit confused because the CHANGELOG changes weren’t getting removed from the PR, but now everything looks great. I'll merge it. Let's check together to make sure the Scoop manifest is generated properly.

@Souvlaki42
Copy link
Contributor Author

Souvlaki42 commented Feb 11, 2025

I was a bit confused because the CHANGELOG changes weren’t getting removed from the PR

All CHANGELOG changes were accidental, but I thought you wanted me to fix the CHANGELOG manually instead of reverting the changes for a while. How is it going?

@babarot babarot mentioned this pull request Feb 11, 2025
@babarot
Copy link
Owner

babarot commented Feb 11, 2025

please merge origin/main into this branch to make ci passed. @Souvlaki42

@Souvlaki42
Copy link
Contributor Author

Souvlaki42 commented Feb 11, 2025

please merge origin/main into this branch to make ci passed. @Souvlaki42

Done.

@babarot babarot merged commit 6350373 into babarot:main Feb 11, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants