-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all goog.object functions #247
Comments
@dehli Can you check, when running bb release with main + bb release with this PR what the total size difference is? We may want to make goog.object lazy if this has an impact on startup time. I'll run some tests myself too. |
When running
247-report.html When drilling down into the google-closure-library, I can see that I'll do some investigation on startup time as well / lazy loading. |
Startup time seems to be unaffected from my testing. I used the following babashka task to compare the two start-up times: (let [num 1000
nbb (fn [] (shell "./cli.js -e nil"))
start (java.time.LocalDateTime/now)
_ (dorun (take num (repeatedly nbb)))
end (java.time.LocalDateTime/now)
diff (java.time.Duration/between start end)]
(println (/ (.toMillis diff) (float num)))
|
OK, this is an insignificant different and I'm ok with adding everything from goog.object in a non-lazy fashion. |
Is your feature request related to a problem? Please describe.
I'd like to use certain
goog.object
functions vianbb
that aren't available (such asgetAllPropertyNames
).Describe the solution you'd like
I'd like to have access to all
goog.object
functions from withinnbb
.Describe alternatives you've considered
I could rewrite the code that uses the non-included
goog.object
functions.Additional context
I unfortunately didn't read the
dev.md
until after coming up with a solution so I have a potential PR here: #248The text was updated successfully, but these errors were encountered: