Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bridge npm package name #6

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Fix for bridge npm package name #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ To address this, we're releasing this bridge package, to allow users to do

```js
peerDependencies: {
"babel-core": "6.x || ^7.0.0-0"
"babel-core": "6.x || ^7.0.0-bridge.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% for if peerDependencies should contain bridge or if ^7.0.0-0 is good enough. I believe the 7.0.0-beta versions are incompatible, so I went with the bridge-specific peer dependency.

}
```

Expand All @@ -44,7 +44,7 @@ to install Babel 6, they could now do


```sh
npm i some-package babel-core@^7.0.0-0 @babel/core
npm i some-package babel-core@^7.0.0-bridge.0 @babel/core
Copy link
Contributor Author

@quisido quisido Jul 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am positive that this needs to contain bridge though, as I was getting prompted for a version when using -0 and was getting errors when choosing -beta.

```

to install the bridge package, and install Babel 7's core.