Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

add flow exceptions for polymorphic types - Ref #109 #118

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jun 2, 2015

For

#109 (comment)

export function foo<X>(x: X): X {
  return x;
}

3:20 error "X" is not defined no-undef

Also for mixed by not visiting those 2 cases. Fixed in babel/babel#1669

hzoo referenced this pull request in wincent/corpus Jun 2, 2015
@hzoo
Copy link
Member Author

hzoo commented Jun 2, 2015

And since there are a lot of globals (Array), etc maybe we can import the definitions in https://github.com/facebook/flow/tree/master/lib core.js?

@hzoo
Copy link
Member Author

hzoo commented Jun 2, 2015

@sebmck this look good? There probably doesn't need to be a PolymorphicTypeAnnotation right?

@hzoo hzoo changed the title add flow exceptions for polymorphic types and mixed - Ref #109 add flow exceptions for polymorphic types - Ref #109 Jun 3, 2015
@hzoo
Copy link
Member Author

hzoo commented Jun 3, 2015

good to merge?

hzoo added a commit that referenced this pull request Jun 3, 2015
add flow exceptions for polymorphic types (<A>) - Ref #109
@hzoo hzoo merged commit 270fd53 into babel:master Jun 3, 2015
nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
add flow exceptions for polymorphic types (<A>) - Ref babel/babel-eslint#109
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant