This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Drop node < 4 #358
Merged
Drop node < 4 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,6 +29,9 @@ | |||
| }, | |||
| "author": "Sebastian McKenzie <sebmck@gmail.com>", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": ">=4" | |||
There was a problem hiding this comment.
Should there be an upper limit placed here? Although it's probably pretty unlikely that a future Node would break this library, we can't know for sure until they're released :)
There was a problem hiding this comment.
If a new node version breaks, we have to take action in any case. If it not breaks, then in this case we wouldn't have to do anything, but with limit we would always need to care. So I think it is fine like it is :)
|
lgtm 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323