Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Update handling of (Rest/Spread)Element for compatibility with babel@7 #463

Closed
wants to merge 2 commits into from

Conversation

lightsofapollo
Copy link

@lightsofapollo lightsofapollo commented Apr 20, 2017

Minimal changes to support babel@7 . Some of the underlying behavior has changed (see isRestProperty) and It may make more sense to add backwards compat to babel@7.

@zertosh
Copy link
Member

zertosh commented Apr 21, 2017

@lightsofapollo, I'll take a look this weekend to see how to make the Babylon 7 transition. I don't think we can just cut over like this. We need to keep to releases for a bit.

@lightsofapollo
Copy link
Author

@zertosh Thanks! mostly using this to unblock myself as I experiment /w babel@7 alpha/beta.

@hzoo
Copy link
Member

hzoo commented Apr 23, 2017

FYI (if it wasn't clear) it doesn't matter as much if babel-eslint updates to babel 7 yet, because there's nothing that connects this tool to babel itself. It works perfectly fine with babel 6/7 since babel-eslint parses the file separately. It is important to do in the future for sure, when we do release 7 and deprecate v6 so the v6 packages won't be updated anymore

However if we can get tests passing then awesome 👍

@hzoo
Copy link
Member

hzoo commented Jun 5, 2017

Yeah if someone wants to make the Babel 7 upgrade I'l make an issue

@hzoo hzoo mentioned this pull request Jun 5, 2017
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants