This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 209
Make 2018 the default ecmaVersion for rules relying on parserOptions #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this has any effect -- ESLint copies the parserOptions object before passing it to parsers. |
Oh, I see. I had forgotten it. But, I think that it's given to |
kaicataldo
force-pushed
the
default-es2018
branch
from
January 8, 2018 22:35
0506460
to
13d7d94
Compare
kaicataldo
commented
Jan 8, 2018
@@ -71,7 +71,7 @@ function parseAndAssertSame(code) { | |||
// assert.equal(esAST, babylonAST); | |||
} | |||
|
|||
describe("babylon-to-esprima", () => { | |||
describe("babylon-to-espree", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct? I'm assuming this is a holdover from a long time ago :)
hzoo
approved these changes
Jan 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 as bugfix
wcjohnson
added a commit
to wcjohnson/lightscript-eslint
that referenced
this pull request
Sep 20, 2018
commit 6aa8b6f Author: Henry Zhu <hi@henryzoo.com> Date: Mon Aug 27 18:09:21 2018 -0400 9.0.0 commit c7ee9ae Author: Brian Ng <bng412@gmail.com> Date: Mon Aug 27 17:04:26 2018 -0500 Bump to babel@7.0.0 🎉 (babel#676) commit 3ece549 Author: Ed Morley <501702+edmorley@users.noreply.github.com> Date: Thu Aug 23 06:23:06 2018 +0100 Docs: Make the default parserOptions more explicit (babel#673) In particular, previously the `.eslintrc` example implied that the default value for `codeFrame` was `false`, when in fact it is `true`: https://github.com/babel/babel-eslint/blob/v9.0.0-beta.3/lib/parse.js#L14 commit 0b36951 Author: Alexandre Borela <alexandre.borela@gmail.com> Date: Thu Aug 23 02:21:45 2018 -0300 Add logical assignment plugin (babel#674) Fix babel#672 commit 5856ff5 Author: Brian Ng <bng412@gmail.com> Date: Tue Aug 21 15:18:02 2018 -0500 Bump some devDeps commit 45938d9 Author: Leo Yin <viztor@users.noreply.github.com> Date: Wed Aug 22 04:00:17 2018 +0800 build(deps): upgrade @babel/* to 7.0.0-rc.2 (babel#668) commit bc97875 Author: Henry Zhu <hi@henryzoo.com> Date: Thu Jul 12 09:50:58 2018 -0400 9.0.0-beta.3 commit 74c5d62 Author: Henry Zhu <hi@henryzoo.com> Date: Thu Jul 12 09:50:30 2018 -0400 update lock commit 6a45632 Author: Mark Tse <neverendingqs@users.noreply.github.com> Date: Thu Jul 12 09:49:43 2018 -0400 chore - fixing eslint-scope to a safe version; resolves babel#656. (babel#657) commit e0119e0 Author: Brian Ng <bng412@gmail.com> Date: Fri Jul 6 11:24:45 2018 -0500 9.0.0-beta.2 commit 198964b Merge: 8948d83 9b06e1f Author: Rubén Norte <rubennorte@gmail.com> Date: Fri Jul 6 17:20:52 2018 +0100 Merge pull request babel#645 from rubennorte/support-new-flow-syntax-in-scope-analysis Support new flow syntax in scope analysis commit 9b06e1f Author: Rubén Norte <rubennorte@fb.com> Date: Fri Jul 6 11:33:37 2018 +0100 Added failing test for variables used in type parameters commit 8948d83 Author: Rubén Norte <rubennorte@gmail.com> Date: Fri Jul 6 14:50:59 2018 +0100 Upgrade Babel to v7.0.0-beta.52 (babel#650) * Upgrade Babel to v7.0.0-beta.52 * Fixed failing test commit 4882b29 Author: Brian Ng <bng412@gmail.com> Date: Fri Jun 29 08:37:18 2018 -0500 9.0.0-beta.1 commit 15e8d6f Author: Rubén Norte <rubennorte@gmail.com> Date: Fri Jun 29 14:26:43 2018 +0100 Breaking: Upgraded Babel to 7.0.0-beta.51 (babel#642) * Upgraded Babel to 7.0.0-beta.51, with changes to decorators * Removed support for Node 4 and added it for Node 10 * nit: fix typo [skip ci] commit e865104 Author: Brian Ng <bng412@gmail.com> Date: Sat Jun 23 08:20:40 2018 -0500 8.2.5 commit 10a402c Author: Brian Ng <bng412@gmail.com> Date: Sat Jun 23 08:20:08 2018 -0500 Revert bump to babel 51 (babel#640) commit 2bd8508 Author: Brian Ng <bng412@gmail.com> Date: Fri Jun 22 13:39:23 2018 -0500 8.2.4 commit 5881648 Author: Brian Ng <bng412@gmail.com> Date: Fri Jun 22 11:12:54 2018 -0500 Add test for template string with object with template string inside (babel#639) Closes babel#538. Fixes babel#537. Now that babel#610 has landed, I wanted to make sure this case was covered. commit 476426a Author: Brian Ng <bng412@gmail.com> Date: Fri Jun 22 11:03:15 2018 -0500 Support OptionalMemberExpression with scope too (babel#634) commit 92874d4 Author: Brian Ng <bng412@gmail.com> Date: Fri Jun 15 16:39:58 2018 -0500 Drop node4 in travis commit d2ac299 Author: Brian Ng <bng412@gmail.com> Date: Mon Jun 11 08:47:15 2018 -0500 Bump Babel deps commit e63962d Author: Cristian Pallarés <cristian@pallares.io> Date: Wed Jun 6 00:18:13 2018 +0200 refactor: rename babylon to @babel/parser commit 873f02f Author: Brian Ng <bng412@gmail.com> Date: Mon Jun 18 16:46:31 2018 -0500 Fix converting template types to handle nested templates (babel#610) Fixes babel#603 (and the fixture from babel#609 works). Reworks our code that converts the format of Babylon template tokens to be a bit more robust, especially with things like nested templates with arrows. (Adapted the logic from https://github.com/eslint/espree/blob/master/lib/token-translator.js) commit 74a3207 Author: Rubén Norte <rubennorte@gmail.com> Date: Fri Jun 15 15:42:05 2018 +0100 Fix token types for experimental operators (babel#632) * Added failing tests * Recognized nullish coalescing, optional chaining and pipeline operators as Punctuator tokens commit e802577 Author: Rubén Norte <rubennorte@gmail.com> Date: Fri Jun 15 15:31:43 2018 +0100 Add support for the optional chaining operator (babel#630) commit ebc46e1 Author: jmurretxactly <35241735+jmurretxactly@users.noreply.github.com> Date: Tue May 8 05:52:59 2018 -0600 don't require unpad per test fixture, fixes babel#572 (babel#618) commit 9641e4b Author: Ankur Oberoi <aoberoi@gmail.com> Date: Fri Apr 13 09:26:41 2018 -0700 updates readme for latest eslint & babel-eslint (babel#607) [skip ci] commit aaeb46b Author: Henry Zhu <hi@henryzoo.com> Date: Fri Apr 13 11:25:03 2018 -0400 8.2.3 commit afc3c87 Author: Henry Zhu <hi@henryzoo.com> Date: Fri Apr 13 11:23:59 2018 -0400 lock to beta.44 commit 92202be Author: Bary Levi <barylevi@gmail.com> Date: Fri Apr 13 18:23:03 2018 +0300 Save babel beta packages as exact versions (babel#606) [skip ci] commit 9a6d663 Author: Daniel Tschinder <daniel.tschinder@researchgate.net> Date: Tue Feb 20 11:57:07 2018 +0100 8.2.2 commit 51afa9e Author: Daniel Tschinder <daniel.tschinder@researchgate.net> Date: Tue Feb 20 11:56:40 2018 +0100 Allow newer versions of babel commit 7928722 Author: Daniel Tschinder <daniel.tschinder@researchgate.net> Date: Tue Feb 20 11:54:09 2018 +0100 Update dependencies commit f958995 Author: Daniel Tschinder <daniel@tschinder.de> Date: Tue Feb 20 11:49:19 2018 +0100 chore(package): update lint-staged to version 6.1.1 (babel#592) Closes babel#539 commit 29b12ab Author: Brian Ng <bng412@gmail.com> Date: Thu Feb 15 21:39:42 2018 -0600 Bump deps (babel#591) commit 236adb8 Author: Toru Nagashima <star.ctor@gmail.com> Date: Wed Jan 17 15:10:55 2018 +0900 Fix: wrong token type of ! and ~ (fixes babel#576) (babel#577) commit bf27f60 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Jan 8 19:15:40 2018 -0500 8.2.1 commit d96ce55 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Jan 8 19:15:22 2018 -0500 fix export change (babel#571) commit ef27670 Author: Kai Cataldo <kaicataldo@gmail.com> Date: Mon Jan 8 18:06:57 2018 -0500 8.2.0 commit eba5920 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Jan 8 17:46:57 2018 -0500 Add other parser plugins, update yarn.lock (babel#569) commit e201fb4 Author: Kai Cataldo <kaicataldo@users.noreply.github.com> Date: Mon Jan 8 17:45:24 2018 -0500 Make 2018 the default ecmaVersion for rules relying on parserOptions (babel#556) commit 1dedd1b Author: jony89 <ariel@emath.co.il> Date: Tue Jan 9 00:40:11 2018 +0200 update babel packages (babel#565) * update babel packages There is some critical bug fixes in version babylon#7.0.0-beta.33 regard `async` - `await` syntax which is needed pretty immediately :) * remove test 42 (test for import type *) `import type *` is invalid, since the namespace can't be a type commit 36bf8b4 Author: Toru Nagashima <star.ctor@gmail.com> Date: Tue Dec 26 10:59:19 2017 +0900 8.1.2 commit 5aaf0e1 Author: Toru Nagashima <star.ctor@gmail.com> Date: Tue Dec 26 10:50:13 2017 +0900 Fix: add Literal type to visitorKeys (babel#562) * Fix: add Literal type to visitorKeys * Fix: use ./visitor-keys commit bf9092a Author: Toru Nagashima <star.ctor@gmail.com> Date: Tue Dec 26 10:49:36 2017 +0900 Fix: ignore eval (fixes babel#560) (babel#561) commit d84b236 Author: Toru Nagashima <star.ctor@gmail.com> Date: Mon Dec 25 15:57:19 2017 +0900 8.1.1 commit e4bed5a Author: Teddy Katz <teddy.katz@gmail.com> Date: Mon Dec 25 01:52:36 2017 -0500 Fix: Prevent parseForESLint() behavior from changing after parse() is called (fixes babel#558)(babel#559) * Prevent parseForESLint() behavior from changing after parse() is called (fixes babel#558, fixes eslint/eslint#9767) * Avoid using the enhanced referencer after monkeypatching * Chore: add test for babel#558 * Pass correct scope analyzer options * fix escope patch and improve tests * remove process.exit(1) commit 893a5e3 Author: Teddy Katz <teddy.katz@gmail.com> Date: Sun Dec 24 02:02:44 2017 -0500 8.1.0 commit bba9d00 Author: Teddy Katz <teddy.katz@gmail.com> Date: Sun Dec 24 02:00:29 2017 -0500 Re-add parseNoPatch function (accidentally removed) (babel#557) commit dbc6546 Author: Toru Nagashima <star.ctor@gmail.com> Date: Sun Dec 24 15:42:17 2017 +0900 Use new scopeManager/visitorKeys APIs (babel#542) (fixes eslint/eslint#9762) commit 1f220c2 Author: Logan Smyth <loganfsmyth@gmail.com> Date: Fri Dec 1 10:06:40 2017 -0800 8.0.3 commit cf5ab03 Author: Logan Smyth <loganfsmyth@gmail.com> Date: Fri Dec 1 10:06:24 2017 -0800 Fix mocha command path. commit 0609da8 Author: Logan Smyth <loganfsmyth@gmail.com> Date: Fri Dec 1 10:05:34 2017 -0800 Lock down dependency versions. commit a0fbd50 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Nov 6 15:00:41 2017 -0500 8.0.2 commit 2004b91 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Nov 6 14:57:56 2017 -0500 require correct deps commit fa56d21 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Nov 6 12:51:19 2017 -0500 Always use unpad (babel#535) commit 295091d Author: Henry Zhu <hi@henryzoo.com> Date: Mon Nov 6 12:47:47 2017 -0500 Allow ^ version for babel dependencies (babel#534) commit d3b8519 Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Date: Mon Nov 6 12:25:35 2017 -0500 fix(package): update babylon to version 7.0.0-beta.31 (babel#533) commit 54ab4ac Author: Henry Zhu <hi@henryzoo.com> Date: Tue Sep 26 16:18:43 2017 -0400 8.0.1 commit c1a7882 Author: Clement Hoang <clement.hoang24@gmail.com> Date: Tue Oct 31 11:50:35 2017 -0700 Update README.md support (babel#531) [skip ci] #linting channel is now archived in babel slack. commit 51100c9 Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Date: Wed Oct 11 14:14:29 2017 +0200 chore(package): update mocha to version 4.0.0 (babel#524) commit 5742b71 Author: Jordan Gensler <jordangens@gmail.com> Date: Tue Sep 26 13:17:44 2017 -0700 Adding optionalCatchBinding to plugins. (babel#521) commit 905887c Author: Henry Zhu <hi@henryzoo.com> Date: Tue Sep 12 09:44:23 2017 -0400 8.0.0 commit 49493e4 Author: Henry Zhu <hi@henryzoo.com> Date: Tue Sep 12 09:42:30 2017 -0400 update to beta.0 commit 42d0c5b Author: Daniel Tschinder <daniel@tschinder.de> Date: Wed Aug 2 14:37:01 2017 +0200 Remove already fixed workaround (babel#508) commit 25bd208 Author: Henry Zhu <hi@henryzoo.com> Date: Wed Jul 26 16:19:29 2017 -0400 8.0.0-alpha.17 commit 1468905 Author: Henry Zhu <hi@henryzoo.com> Date: Wed Jul 26 16:18:45 2017 -0400 alpha.17 commit 57c133e Author: Henry Zhu <hi@henryzoo.com> Date: Thu Jul 13 13:01:31 2017 -0400 8.0.0-alpha.15 commit 1e41162 Author: Henry Zhu <hi@henryzoo.com> Date: Thu Jul 13 12:58:45 2017 -0400 update (babel#504) commit c31b577 Author: Evan Brodie <ecbrodie@users.noreply.github.com> Date: Sun Jul 9 21:03:59 2017 -0400 Readme update usage section (babel#501) [skip ci] * Updates README: Consolidates versioning table Basically a revert of 52b4a13. It is easier to read a single table instead of two locations in the README for the version compatabilities between ESLint and babel-eslint * Updates README: Add yarn command for installation * [skip ci] commit c2626f9 Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Date: Sun Jun 25 08:30:29 2017 -0700 Update eslint to the latest version 🚀 (babel#500) * chore(package): update eslint to version 4.1.0 * escope -> eslint-scope * Fix linting commit 3c6b2de Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Date: Thu Jun 22 13:18:47 2017 -0700 chore(package): update husky to version 0.14.0 (babel#498) commit e052d5a Author: Kevin Mårtensson <kevinmartensson@gmail.com> Date: Tue Jun 20 23:49:46 2017 +0200 Update install instructions to use latest stable release (babel#497) [skip ci] commit 8e3e088 Author: Henry Zhu <hi@henryzoo.com> Date: Sun Jun 18 18:33:40 2017 -0400 8.0.0-alpha.13 commit f757e22 Merge: 37f9242 5736be6 Author: Henry Zhu <hi@henryzoo.com> Date: Sun Jun 18 18:30:59 2017 -0400 Merge pull request babel#493 from danez/regression-test Test for babylon regression commit 5736be6 Author: Daniel Tschinder <daniel.tschinder@researchgate.net> Date: Sun Jun 18 23:12:08 2017 +0200 Update babylon commit 37f9242 Author: Brian Ng <bng412@gmail.com> Date: Sat Jun 17 14:14:42 2017 -0500 Add Prettier (babel#491) commit d0c3223 Author: Daniel Tschinder <daniel.tschinder@researchgate.net> Date: Sat Jun 17 21:12:07 2017 +0200 Test for babylon regression commit 945f00a Author: Henry Zhu <hi@henryzoo.com> Date: Fri Jun 16 16:56:32 2017 -0400 8.0.0-alpha.12 commit 39b4a6a Author: Daniel Tschinder <daniel@tschinder.de> Date: Thu Jun 15 23:03:02 2017 +0200 Use babylon estree and ranges (babel#489) commit 1aedb95 Author: Mark Banner <standard8@mozilla.com> Date: Thu Jun 8 17:23:08 2017 +0100 Fix: allow options to be optional when monkey patching escope.analyze (fixes babel#470). (babel#484) commit a8003c0 Author: Reyad Attiyat <reyad.attiyat@gmail.com> Date: Tue Jun 6 20:38:49 2017 -0500 Use Node 8 and drop Node 5 from travis (babel#483) * Use Node 8 and drop Node 5 from travis * switch the order [skip ci] commit c66ec51 Author: Reyad Attiyat <reyad.attiyat@gmail.com> Date: Tue Jun 6 20:37:57 2017 -0500 Update to Babylon 7 (fixes babel#481) (babel#482) * Update to Babylon 7 (fixes babel#481) * Pin dependencies to alpha version * fix deprecation, add other plugins * oops * Update index.js * Add tests for private class properties with rules no-undef no-unused-vars commit 54ed517 Author: Reyad Attiyat <reyad.attiyat@gmail.com> Date: Mon May 29 20:41:14 2017 -0500 Fix: Convert RegExpLieteral value to RegExp object (fixes babel#477) (babel#478) commit 94bb5a1 Author: Sebastian McKenzie <sebmck@fb.com> Date: Fri Apr 21 22:14:19 2017 +0100 7.2.3 commit dfaff04 Author: Andres Suarez <zertosh@gmail.com> Date: Fri Apr 21 11:48:52 2017 -0400 Fix flow type spread handling (babel#465) commit f59d200 Author: Henry Zhu <hi@henryzoo.com> Date: Wed Apr 12 12:07:05 2017 -0400 7.2.2 commit 8622009 Author: Vitor Balocco <vitorbal@gmail.com> Date: Wed Apr 12 17:59:23 2017 +0200 Fix: use eslint-scope instead of escope if present (babel#461) commit 0f611b8 Author: Andres Suarez <zertosh@gmail.com> Date: Thu Mar 30 13:49:51 2017 -0400 Separate finding peer deps from monkeypatching (babel#460) commit 1201e12 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 19:36:10 2017 -0400 Remove unused .gitmodules (babel#457) commit a750684 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 19:32:05 2017 -0400 Use dedent for unpadding (babel#456) commit cdb92fe Merge: 21dac73 ec14787 Author: Henry Zhu <hi@henryzoo.com> Date: Sat Mar 25 19:15:23 2017 -0400 Merge pull request babel#455 from babel/babylon-to-espree-tidy Tidy up babylon-to-espree commit ec14787 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 18:03:17 2017 -0400 Enable strict mode in all of babylon-to-espree commit 6c5beec Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 18:01:13 2017 -0400 Move ast convert steps to babylon-to-espree commit d2ce789 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 17:42:51 2017 -0400 Use for-loop for template literal conversion commit 539af05 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 17:36:20 2017 -0400 Only iterate over tokens once commit 06c3a31 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 17:28:01 2017 -0400 Inline fixDirectives and use for-loop commit 5d32ad0 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 17:07:41 2017 -0400 Consolidate versions of "convertComments" commit 2541fc9 Author: Andres Suarez <zertosh@gmail.com> Date: Sat Mar 25 00:18:57 2017 -0400 toAst pass "source" in state instead of keeping in scope commit 21dac73 Author: Andres Suarez <zertosh@gmail.com> Date: Thu Mar 23 15:46:48 2017 -0400 Add type parameter scope tests (babel#454) commit 3cda62e Author: Henry Zhu <hi@henryzoo.com> Date: Thu Mar 23 14:03:23 2017 -0400 7.2.1 commit 5626de1 Author: Andres Suarez <zertosh@gmail.com> Date: Thu Mar 23 14:02:24 2017 -0400 Remove left over eslint 2 estraverse code (babel#452) This was missed in babel#361 commit b5fb53b Author: Andres Suarez <zertosh@gmail.com> Date: Thu Mar 23 12:49:19 2017 -0400 Fix type param and interface declaration scoping (babel#449) commit f1cee0f Author: Andres Suarez <zertosh@gmail.com> Date: Wed Mar 22 22:35:31 2017 -0400 Remove lodash dependency (babel#450) commit eb05812 Author: Andres Suarez <zertosh@gmail.com> Date: Wed Mar 22 22:34:13 2017 -0400 Format non-regression errors for legibility (babel#451) commit 7972a05 Author: Luís Couto <hello@luiscouto.pt> Date: Tue Mar 21 00:11:30 2017 +0000 Update README.md with codeFrame option (babel#448) commit 4db4db5 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Mar 20 17:53:26 2017 -0400 7.2.0 commit 4499412 Author: wtgtybhertgeghgtwtg <wtgtybhertgeghgtwtg@gmail.com> Date: Mon Mar 20 14:50:09 2017 -0700 Use `lodash` instead of `lodash.pickby`. (babel#435) commit a2c3b30 Author: Alex Rattray <rattray.alex@gmail.com> Date: Mon Mar 20 14:46:07 2017 -0700 [flow] Process polymorphic type bounds on functions (babel#444) commit 515adef Author: Luís Couto <hello@luiscouto.pt> Date: Mon Mar 20 21:45:11 2017 +0000 Add option to disable code frame. (babel#446) * Add option to disable code hightlight. * Rename codeHighlight with codeFrame * Add codeFrame tests * Remove colors from test assertions commit ce66e73 Merge: bdeb86f b49ab20 Author: Henry Zhu <hi@henryzoo.com> Date: Mon Mar 20 11:44:33 2017 -0400 Merge pull request babel#447 from kaicataldo/clean-up-eslint Chore: Clean up and upgrades commit b49ab20 Author: Kai Cataldo <kaicataldo@gmail.com> Date: Mon Mar 20 10:33:14 2017 -0400 Updates ESLint version/remove unnecessary config commit 702d6b8 Author: Kai Cataldo <kaicataldo@gmail.com> Date: Mon Mar 20 10:27:28 2017 -0400 Remove broken ESLint tests commit 6b4c4ca Author: Kai Cataldo <kaicataldo@gmail.com> Date: Sat Mar 11 22:15:47 2017 -0500 Upgrade outdated dependencies
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some core rules (and potentially custom rules in the ecosystem) rely on checking
parserOptions
in the rules themselves. Technically, since Babylon always parses the latest (including experimental) syntax, this should be set to the latest ESLint supports (currently 2018).