Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Ensure that escope is parsing decorators. #75

Closed
wants to merge 2 commits into from
Closed

Ensure that escope is parsing decorators. #75

wants to merge 2 commits into from

Conversation

matteosuppo
Copy link

Address issue #72

@slonoed
Copy link

slonoed commented May 1, 2015

@matteosuppo what with this PR?

@matteosuppo
Copy link
Author

It's a step toward fixing issue 72

Il giorno ven 1 mag 2015 18:45 Dmitry Manannikov notifications@github.com
ha scritto:

@matteosuppo https://github.com/matteosuppo what with this PR?


Reply to this email directly or view it on GitHub
#75 (comment).

@MoOx
Copy link

MoOx commented May 14, 2015

@matteosuppo do you need any hand to update this PR ?
I would love to see this one ready to merge :)

@matteosuppo
Copy link
Author

I'm not even sure if they want to merge it

Il giorno gio 14 mag 2015 14:03 Maxime Thirouin notifications@github.com
ha scritto:

@matteosuppo https://github.com/matteosuppo do you need any hand to
update this PR ?
I would love to see this one ready to merge :)


Reply to this email directly or view it on GitHub
#75 (comment).

@MoOx
Copy link

MoOx commented May 14, 2015

Who doesn't want to merge a PR that fix an issue ?
Maybe you can add tests ? Not sure if it's necessary here but that might help.

@sebmck
Copy link
Contributor

sebmck commented May 14, 2015

I haven't merged this because I'm not comfortable with the code as I'm not even show what this does. Also #88.

@MoOx
Copy link

MoOx commented May 14, 2015

That why I think tests might help here :)
I saw this issue as well, I am sure you are very busy. I don't want to annoy you :)

@hzoo
Copy link
Member

hzoo commented May 20, 2015

Thanks for the initial PR @matteosuppo! Should be good in 3.1.6.

@hzoo hzoo closed this May 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants