-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump loader-utils and use getOptions #391
Conversation
This breaks as the new loader-utils version drops support for node < 4 |
75124ac
to
77e63e6
Compare
Codecov Report
@@ Coverage Diff @@
## 7.0 #391 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 6 6
Lines 160 160
Branches 35 35
=======================================
Hits 131 131
Misses 13 13
Partials 16 16
Continue to review full report at Codecov.
|
Considering that Node 4 is the oldest supported version of Node (0.10 and 0.12 being dead), one could argue it's not a breaking change. |
+1 |
Can we release babel-loader@7 without waiting for Babel 7? Doesn't seem like they have to track each other. |
+1 |
@danez - Nothing related to Webpack 2.x supports node < 4. Agree with @Timer, I wouldn't consider this breaking as support for .10 / .12 was never there to begin with as support was dropped when NodeJS officially dropped their support of these versions.
This has been handled as a |
I've been trying to get a new project up and this issue is so far very difficult to solve. This plugin is now at odds with most other loaders and loaderUtils does not support parseQuery anymore :( I'd love to see this (or something similar) get merged in soon :D |
Please release this asap, it's causing issues on our app. |
...We are waiting for this release |
The deprecation warning is now fixed in v7.0.0-alpha.2 |
@danez |
but not for node <4 |
Ah, sorry, I read it incorrectly. |
Been through a couple walls of text. Using Node 7.4.0 with latest webpack and babel-loader. Still getting this error. Can someone summarize what's wrong and what needs to be done? |
@corysimmons if you're using If you are on |
|
Yup, if you want to be more explicit @7.0.0-beta.1 |
Thanks, works. 👍 |
Does babel-loader@next work with babel-core 6? |
@Vanuan Yes babel-loader does work with babel-core 6.x |
Fixes warning:
Ref: webpack/loader-utils#56