Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing main #903

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Fix failing main #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f24a83
chore: update caniuse-lite
JLHwung Apr 20, 2021
1aadd2b
chore: update webpack to 5.34.0
JLHwung Apr 20, 2021
b179fb3
test: update assertions on webpack 5 behaviour
JLHwung Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"react-intl-webpack-plugin": "^0.3.0",
"rimraf": "^3.0.0",
"semver": "7.3.2",
"webpack": "^5.4.0"
"webpack": "^5.34.0"
},
"scripts": {
"clean": "rimraf lib/",
Expand Down
12 changes: 6 additions & 6 deletions test/sourcemaps.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ test.cb("should output webpack's sourcemap properly when set 'inline'", t => {

if (isWebpack5) {
t.is(
mapObj.sources[0],
mapObj.sources[3],
"webpack://babel-loader/./test/fixtures/basic.js",
);

// Ensure that the map contains the original code, not the compiled src.
t.falsy(mapObj.sourcesContent[2].includes("__esModule"));
t.falsy(mapObj.sourcesContent[3].includes("__esModule"));
} else {
t.is(mapObj.sources[1], "webpack:///./test/fixtures/basic.js");

Expand Down Expand Up @@ -232,13 +232,13 @@ test.cb("should disable sourcemap output with 'sourceMaps:false'", t => {

if (isWebpack5) {
t.is(
mapObj.sources[0],
mapObj.sources[3],
"webpack://babel-loader/./test/fixtures/basic.js",
);

// Ensure that the code contains Babel's compiled output, because
// sourcemaps from Babel are disabled.
t.truthy(mapObj.sourcesContent[2].includes("__esModule"));
t.truthy(mapObj.sourcesContent[3].includes("__esModule"));
} else {
t.is(mapObj.sources[1], "webpack:///./test/fixtures/basic.js");

Expand Down Expand Up @@ -295,13 +295,13 @@ test.cb("should disable sourcemap output with 'sourceMap:false'", t => {

if (isWebpack5) {
t.is(
mapObj.sources[0],
mapObj.sources[3],
"webpack://babel-loader/./test/fixtures/basic.js",
);

// Ensure that the code contains Babel's compiled output, because
// sourcemaps from Babel are disabled.
t.truthy(mapObj.sourcesContent[2].includes("__esModule"));
t.truthy(mapObj.sourcesContent[3].includes("__esModule"));
} else {
t.is(mapObj.sources[1], "webpack:///./test/fixtures/basic.js");

Expand Down
Loading