Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix destructuring of empty string #13444

Merged
merged 4 commits into from
Jun 14, 2021
Merged

fix destructuring of empty string #13444

merged 4 commits into from
Jun 14, 2021

Conversation

lala7573
Copy link
Contributor

@lala7573 lala7573 commented Jun 9, 2021 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #13421
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 9, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c54ef3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

jridgewell
jridgewell approved these changes Jun 9, 2021
View reviewed changes
packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 9, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46827/

@nicolo-ribaudo
Copy link
Member

Can you run OVERWRITE=true yarn jest to update the failing test?

@nicolo-ribaudo
Copy link
Member

It seems like there are some unrelated changes caused by outdated dependencies 🤔

If CI fails, try running yarn and then re-generate the fixtures again.

@lala7573
Copy link
Contributor Author

@nicolo-ribaudo
I removed node_modules and reinstalled using yarn and then re-generate the fixtures. And the ci tests seem almost done.
Is there anything that I should have to do with this pr? Please tell me!!
Thank you for your kind guides and feedbacks.

@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title fix destructuring empty string fix destructuring of empty string Jun 14, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 950d351 into babel:main Jun 14, 2021
@lala7573 lala7573 deleted the fix-13421 branch June 15, 2021 10:14
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 15, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 22, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@jridgewell jridgewell jridgewell approved these changes

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Destructuring empty string to array causes runtime error
5 participants
@lala7573 @babel-bot @nicolo-ribaudo @jridgewell @fedeci