Use regenerator-transform to implement babel-plugin-transform-regenerator #4881

benjamn · 2016-11-21T22:00:26Z

Q	A
Bug fix?	no
Breaking change?	no
New feature?	no
Deprecations?	no
Spec compliancy?	no
Tests added/pass?	no/yes
Fixed tickets
License	MIT
Doc PR	no
Dependency Changes	yes

I'm very happy to say I finally got around to finishing the work that @kittens prototyped in facebook/regenerator#222.

Just as babel-runtime now depends on the external regenerator-runtime package, I believe it makes sense for babel-plugin-transform-regenerator to become a thin wrapper around regenerator-transform, a pure-Babel plugin implementing exactly the same logic as before, without any extraneous dependencies like defs, recast, or ast-types.

Though I believe this pull request is safe to merge, you should probably wait to merge it until facebook/regenerator#259 is merged. That pull request also provides more explanation of why I think moving the implementation of Regenerator back to its original repository is a good idea. I'm happy to compromise on anything necessary to make this happen.

Note that the regenerator-transform version is pegged to an exact version (0.9.7). Past experience has taught me that releasing new versions of Regenerator is almost impossible if client projects are allowed to pull in new patch versions automatically. I will happily submit a pull request whenever a new version is released.

benjamn · 2016-11-21T22:05:36Z

Note that TEST_GREP=regenerator make test-only (10 tests) still passes, in addition to the numerous tests over at https://github.com/facebook/regenerator/tree/master/test.

codecov-io · 2016-11-21T22:09:10Z

Current coverage is 89.14% (diff: 100%)

No coverage report found for master at 723c90e.

Powered by Codecov. Last update 723c90e...4101dc9

benjamn · 2016-11-30T19:13:15Z

facebook/regenerator#259 has now been merged, so I believe this PR is ready for serious consideration!

benjamn · 2016-12-01T04:11:41Z

Here are three bugs that I've fixed in https://github.com/facebook/regenerator since merging facebook/regenerator#259:

Keep directive prologues at top of function facebook/regenerator#248
CallExpression not processed in correct order in complex case facebook/regenerator#244
Nested arrow async functions facebook/regenerator#230 (technically regenerator-preset-specific)

These bugs would also be fixed in Babel when/if this PR gets merged!

hzoo · 2016-12-01T15:59:16Z

What should we do about tests, etc? Right now we are just going to be calling out to regenerator-transform. I guess we can delete .test at least

Also realized npmignore didn't ignore .test or src folders

benjamn · 2016-12-01T16:01:18Z

I think the tests in https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-regenerator/test are still useful as integration tests, but .test should be deleted (will do).

…ator. Though I believe this is safe to merge, you may want to wait to merge it until facebook/regenerator#259 is merged. That pull request also provides more explanation of why I think moving the implementation of Regenerator back to its original repository is a good idea. I'm happy to compromise on anything necessary to make this happen. Note that the regenerator-transform version is pegged to an exact version (0.9.7). Past experience has taught me that releasing new versions of Regenerator is almost impossible if client projects are allowed to pull in new patch versions automatically. I will happily submit a pull request whenever a new version is released.

hzoo · 2016-12-02T16:51:27Z

Cool 😄

hzoo · 2016-12-08T17:04:46Z

packages/babel-plugin-transform-regenerator/src/index.js

-export default function () {
-  return require("./visit");
-}
+export default require("regenerator-transform");


Looking at https://unpkg.com/babel-plugin-transform-regenerator@6.16.1/lib/index.js

I think due to module.exports = exports["default"]; this needs to be .default? Although not sure why there aren't any failing tests

or we use import and the export it? @benjamn

What about export { default } from "regenerator-transform"? Or even export * from "regenerator-transform"?

hzoo · 2016-12-08T20:17:09Z

Alright let's do it then 🎉 thanks for taking this on @benjamn

* master: make installing runtime/transform-runtime clearer [skip ci] (babel#4991) Add example to es2015-unicode-regex [skip ci] (babel#4983) v6.20.3 Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978) v6.20.2 fix object spread (babel#4976) fix clean lib update readme [skip ci] v6.20.1 Fix nested object spread (babel#4974) v6.20.0 v6.20.0 changelog [skip ci] (babel#4971) Raise limit on code size before compacting (babel#4965) Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881) Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths (babel#4876) Hoist generateDeclaredUidIdentifier helper function (babel#4934)

* master: (89 commits) fix sizing [skip ci] typo [skip ci] changelog for v6.20.1 to v6.20.3 [skip ci] mention repl/link [skip ci] add semver label [skip ci] Fix links in CONTRIBUTING.md [skip ci] (babel#4989) make installing runtime/transform-runtime clearer [skip ci] (babel#4991) Add example to es2015-unicode-regex [skip ci] (babel#4983) v6.20.3 Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978) v6.20.2 fix object spread (babel#4976) fix clean lib update readme [skip ci] v6.20.1 Fix nested object spread (babel#4974) v6.20.0 v6.20.0 changelog [skip ci] (babel#4971) Raise limit on code size before compacting (babel#4965) Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881) ...

…ator (babel#4881) * Use regenerator-transform to implement babel-plugin-transform-regenerator. Though I believe this is safe to merge, you may want to wait to merge it until facebook/regenerator#259 is merged. That pull request also provides more explanation of why I think moving the implementation of Regenerator back to its original repository is a good idea. I'm happy to compromise on anything necessary to make this happen. Note that the regenerator-transform version is pegged to an exact version (0.9.7). Past experience has taught me that releasing new versions of Regenerator is almost impossible if client projects are allowed to pull in new patch versions automatically. I will happily submit a pull request whenever a new version is released. * Remove never-used babel-plugin-transform-regenerator/.test directory. * regenerator-transform to 0.9.8

benjamn force-pushed the use-regenerator-transform branch from 77dad0d to 5aab8da Compare December 1, 2016 02:58

benjamn force-pushed the use-regenerator-transform branch from 5aab8da to 8d4e01e Compare December 1, 2016 04:12

This was referenced Dec 1, 2016

Yield calling Yield combines two variables facebook/regenerator#218

Closed

Yielded values stomp on each other from regenerator. #2385

Closed

hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 1, 2016

benjamn added 2 commits December 1, 2016 14:15

Remove never-used babel-plugin-transform-regenerator/.test directory.

0e70395

benjamn force-pushed the use-regenerator-transform branch from d4d5407 to 0e70395 Compare December 1, 2016 19:16

This was referenced Dec 6, 2016

Fix Babel issues in tests by applying the right transforms facebook/create-react-app#1179

Merged

Add /.test and /src to babel-plugin-transform-regenerator `.npm… #4961

Merged

hzoo reviewed Dec 8, 2016

View reviewed changes

regenerator-transform to 0.9.8

4101dc9

hzoo mentioned this pull request Dec 8, 2016

compile with loose mode facebook/regenerator#265

Merged

hzoo merged commit 16c84fb into babel:master Dec 8, 2016

davewasmer mentioned this pull request Dec 8, 2016

Remove extra babel transform when upstream fixes land denali-js/core#234

Closed

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use regenerator-transform to implement babel-plugin-transform-regenerator #4881

Use regenerator-transform to implement babel-plugin-transform-regenerator #4881

benjamn commented Nov 21, 2016 •

edited

Loading

benjamn commented Nov 21, 2016 •

edited

Loading

codecov-io commented Nov 21, 2016 •

edited

Loading

benjamn commented Nov 30, 2016

benjamn commented Dec 1, 2016 •

edited

Loading

hzoo commented Dec 1, 2016 •

edited

Loading

benjamn commented Dec 1, 2016

hzoo commented Dec 2, 2016

hzoo Dec 8, 2016 •

edited

Loading

benjamn Dec 8, 2016

hzoo commented Dec 8, 2016 •

edited

Loading

Use regenerator-transform to implement babel-plugin-transform-regenerator #4881

Use regenerator-transform to implement babel-plugin-transform-regenerator #4881

Conversation

benjamn commented Nov 21, 2016 • edited Loading

benjamn commented Nov 21, 2016 • edited Loading

codecov-io commented Nov 21, 2016 • edited Loading

Current coverage is 89.14% (diff: 100%)

benjamn commented Nov 30, 2016

benjamn commented Dec 1, 2016 • edited Loading

hzoo commented Dec 1, 2016 • edited Loading

benjamn commented Dec 1, 2016

hzoo commented Dec 2, 2016

hzoo Dec 8, 2016 • edited Loading

Choose a reason for hiding this comment

benjamn Dec 8, 2016

Choose a reason for hiding this comment

hzoo commented Dec 8, 2016 • edited Loading

benjamn commented Nov 21, 2016 •

edited

Loading

benjamn commented Nov 21, 2016 •

edited

Loading

codecov-io commented Nov 21, 2016 •

edited

Loading

benjamn commented Dec 1, 2016 •

edited

Loading

hzoo commented Dec 1, 2016 •

edited

Loading

hzoo Dec 8, 2016 •

edited

Loading

hzoo commented Dec 8, 2016 •

edited

Loading