Class private properties #7555

CodingItWrong · 2018-03-12T20:04:11Z

Q	A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR
Any Dependency Changes?
License	MIT

Rebases #6120 off of latest master, and attempts to get tests passing.

Note: I need to do some more significant rebasing; the work from #6120 was applied to the old transform-class-properties folder, not the new proposal-class-properties folder.

babel-bot · 2018-03-12T20:10:41Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7334/

babel-bot · 2018-03-12T20:10:42Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7216/

littledan · 2018-03-13T11:29:01Z

Great to see this being picked up. Thanks for your hard work here!

It would be a good next step if you could get the test262 tests passing as well. These test against several things that were buggy in the previous PR (see my review of that PR for an explanation). You can run test262 tests against Babel by using test262-harness with the --babelPresets flag, based on a JS engine binary from jsvu. Please let me know on this thread if you need any help with the setup (cc @mathiasbynens ).

CodingItWrong · 2018-03-13T13:07:42Z

thanks @littledan, that sounds good. after i finish correcting the rebase on this pr, the test262 suite will be my next step!

xtuc · 2018-03-14T13:01:43Z

codemods/babel-plugin-codemod-optional-catch-binding/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@babel/plugin-codemod-optional-catch-binding",
-  "version": "7.0.0-beta.40",
+  "version": "0.0.1",


You don't need to worry about the version, they are managed by lerna

xtuc · 2018-03-14T13:02:42Z

packages/babel-helpers/src/helpers.js

+helpers.classPrivateFieldKey = () => template.program.ast`
+  var id = 0;
+  export default function _classPrivateFieldKey(name) {
+    // Can we use a middle finger emoji?


Aha that would be so cool, but the comment is kinda useless.

Please remove my snark.

CodingItWrong · 2018-03-15T15:31:57Z

@littledan ok, I could use a pointer on how to run test262. I tried this:

cd test262
test262-harness --babelPresets test/**/*.js

But I get the following error:

ERROR Error: Couldn't find preset "/Users/josh/.nvm/versions/node/v8.9.4/lib/node_modules/test262-harness/node_modules/babel-preset-test/harness/arrayContains.js" relative to directory "/Users/josh/apps/babel/test262"

Can you help me interpret what I should be doing to fix that error? Also, what should I do to run the tests against my local babel checkout?

littledan · 2018-03-15T15:51:43Z

@CodingItWrong The --babelPresets flag should have an argument passed to it, such as stage-0. To run against your local Babel checkout, from the directory that npm installed test262-harness into, use the npm link command.

@hzoo

Still needs @hzoo to publish a new version of babylon.

Re: tc39/proposal-class-fields#43

Yes, the output is uglier. But, this is necessary for me to refactor `replaceSupers` for babel#7733, which is necessary for both babel#7555 and babel#7553 (comment). I'm still in the middle of cleaning up all this code. Don't expect `transformClass` to survive much longer as it's written currently.

littledan · 2018-04-19T14:56:24Z

How is this PR going? Is there anything more I could do?

CodingItWrong · 2018-04-19T15:00:05Z

@littledan it sounds like @jridgewell is intending to pick up the work in a sequence of smaller PRs like #7750. If I get a chance to contribute again, I'll follow the same sequence 👍

jridgewell · 2018-04-19T17:25:41Z

@littledan: I'm slowly picking away at this through smaller PRs to fix classes.

Particularly, once I get #7750 in, I can work on #7733, which'll remove a few hundred lines from this PR.

littledan · 2018-04-19T18:51:51Z

Great, thanks @jridgewell !

Yes, the output is uglier. But, this is necessary for me to refactor `replaceSupers` for babel#7733, which is necessary for both babel#7555 and babel#7553 (comment). I'm still in the middle of cleaning up all this code. Don't expect `transformClass` to survive much longer as it's written currently.

Yes, the output is uglier. But, this is necessary for me to refactor `replaceSupers` for #7733, which is necessary for both #7555 and #7553 (comment). I'm still in the middle of cleaning up all this code. Don't expect `transformClass` to survive much longer as it's written currently.

billinghamj · 2018-04-25T20:59:57Z

It looks like all those PRs are merged now (awesome work!) - so I guess the question now is: what are the remaining steps?

jridgewell · 2018-04-26T02:31:21Z

Final step is the class-properties transform! Working on it now.

jridgewell · 2018-04-27T03:02:09Z

Have an updated branch on my personal repo. Relevant commit for the transform is jridgewell@d004652 (at 177 fewer lines!). All that's needed are tests.

vjpr · 2018-05-06T15:28:38Z

Superceded by #7842

hzoo · 2018-05-19T15:15:39Z

Closing via #7842 👍

billinghamj mentioned this pull request Mar 13, 2018

Class private properties #6120

Closed

littledan mentioned this pull request Mar 13, 2018

Correctly assign super properties #7553

Closed

CodingItWrong force-pushed the class-private-properties branch from 7d511ff to 68ee94a Compare March 13, 2018 20:59

xtuc reviewed Mar 14, 2018

View reviewed changes

CodingItWrong force-pushed the class-private-properties branch from 741ff33 to a8e842d Compare March 15, 2018 15:13

jridgewell and others added 19 commits March 16, 2018 16:57

tmp

ebe0da9

Resolve merge conflicts in test

acac2e5

Cleanup code

8f2cbe6

Final fixes

f39bb5b

fixes

851122c

Limit to node 6

7983ca3

Remove duplicate tests

337ea58

Memoize ThisExpression and PrivateName

fc47166

Fix postfix update expressions

2beae33

Fix postfix, again.

9301279

Review updates

db8c209

Slight cleanup

03f83df

Use new PrivateName AST

3fd0c0f

Fixes

6cd376f

No need for a visitor

ef71378

Update code to match new AST

b849b5f

Still needs @hzoo to publish a new version of babylon.

Ensure the ClassHeritage executes in outerPrivateEnvironment

7dd7c07

Ensure inherited statics throw in loose mode

982e28f

Re: tc39/proposal-class-fields#43

Merge conflicts

c322a0c

Allow duplicate public fields

a8f8d7e

CodingItWrong force-pushed the class-private-properties branch 2 times, most recently from 93391d2 to 288da8b Compare March 20, 2018 15:59

Revert change from using rest/spread to arguments

ccd9410

CodingItWrong force-pushed the class-private-properties branch from 288da8b to ccd9410 Compare March 20, 2018 16:06

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Class Fields labels Mar 31, 2018

nicolo-ribaudo mentioned this pull request Mar 31, 2018

Decorators #7542

Closed

2 tasks

jridgewell mentioned this pull request Apr 4, 2018

Private Properties phase 1 #7666

Merged

jridgewell mentioned this pull request Apr 18, 2018

Move more class state out of replaceSupers #7750

Merged

jridgewell mentioned this pull request Apr 30, 2018

Class private properties #7842

Merged

This was referenced May 6, 2018

Tooling implementation status tc39/proposal-private-methods#32

Open

Tooling implementation status tc39/proposal-class-fields#57

Open

hzoo closed this May 19, 2018

bakkot mentioned this pull request May 31, 2018

A summary of feedback regarding the # sigil prefix tc39/proposal-class-fields#100

Closed

gverni mentioned this pull request Dec 3, 2018

Drop Android 4.4 support in the upcoming major sweetalert2/sweetalert2#1319

Closed

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class private properties #7555

Class private properties #7555

CodingItWrong commented Mar 12, 2018 •

edited

Loading

babel-bot commented Mar 12, 2018 •

edited

Loading

babel-bot commented Mar 12, 2018

littledan commented Mar 13, 2018

CodingItWrong commented Mar 13, 2018

xtuc Mar 14, 2018

xtuc Mar 14, 2018

jridgewell Mar 16, 2018

CodingItWrong commented Mar 15, 2018

littledan commented Mar 15, 2018

littledan commented Apr 19, 2018

CodingItWrong commented Apr 19, 2018

jridgewell commented Apr 19, 2018

littledan commented Apr 19, 2018

billinghamj commented Apr 25, 2018

jridgewell commented Apr 26, 2018

jridgewell commented Apr 27, 2018

vjpr commented May 6, 2018

hzoo commented May 19, 2018

Class private properties #7555

Class private properties #7555

Conversation

CodingItWrong commented Mar 12, 2018 • edited Loading

babel-bot commented Mar 12, 2018 • edited Loading

babel-bot commented Mar 12, 2018

littledan commented Mar 13, 2018

CodingItWrong commented Mar 13, 2018

xtuc Mar 14, 2018

Choose a reason for hiding this comment

xtuc Mar 14, 2018

Choose a reason for hiding this comment

jridgewell Mar 16, 2018

Choose a reason for hiding this comment

CodingItWrong commented Mar 15, 2018

littledan commented Mar 15, 2018

littledan commented Apr 19, 2018

CodingItWrong commented Apr 19, 2018

jridgewell commented Apr 19, 2018

littledan commented Apr 19, 2018

billinghamj commented Apr 25, 2018

jridgewell commented Apr 26, 2018

jridgewell commented Apr 27, 2018

vjpr commented May 6, 2018

hzoo commented May 19, 2018

CodingItWrong commented Mar 12, 2018 •

edited

Loading

babel-bot commented Mar 12, 2018 •

edited

Loading