Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

[7.0] Throw on trailing comma with rest-spread #290

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Conversation

danez
Copy link
Member

@danez danez commented Jan 12, 2017

Q A
Bug fix? yes
Breaking change? yes
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets
License MIT

This reverts commit 5bac6e8. #154

Fixes babel/babel#5092

@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 97.46% (diff: 99.36%)

Merging #290 into 7.0 will decrease coverage by 0.11%

@@                7.0       #290   diff @@
==========================================
  Files            20         21     +1   
  Lines          3967       3991    +24   
  Methods         469        491    +22   
  Messages          0          0          
  Branches       1175       1164    -11   
==========================================
+ Hits           3871       3890    +19   
- Misses           42         44     +2   
- Partials         54         57     +3   

Powered by Codecov. Last update ed625cb...6a19abe

@danez danez changed the base branch from master to 7.0 January 12, 2017 21:39
@danez
Copy link
Member Author

danez commented Jan 16, 2017

Seems travis is confused and still tests 0.10 and 0.12 in this PR although base is 7.0

@loganfsmyth
Copy link
Member

loganfsmyth commented Feb 21, 2017

(Edit) Nevermind, my test case was wrong :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants