Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Add babel semi #121

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Add babel semi #121

merged 2 commits into from
Feb 27, 2017

Conversation

aaronjensen
Copy link
Contributor

Fixes #43

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! I'm not sure when I got review privileges here, but here I am, leaving a LGTM review! I need this for: prettier/prettier-eslint#32

Thanks!


// babel, "never"
{ code: "class Foo { bar = 'example' }", options: ["never"] },
{ code: "class Foo { static bar = 'example' }", options: ["never"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:party_parrot: 🎉

@kentcdodds
Copy link
Member

Also, I created a minimal reproducible example of the issue I referenced and when I use this branch against my code it is able to fix everything as expected: kentcdodds/eslint-fix-public-class-fields-semi@6628a70

@kentcdodds kentcdodds merged commit 14a367f into babel:master Feb 27, 2017
@aaronjensen aaronjensen deleted the add-babel-semi branch February 27, 2017 20:20
nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
* Add semi from eslint

* Add ClassProperty support to semi rule

Fixes babel/eslint-plugin-babel#43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants