Fix bug where invalid array length throws (close #206) (#215)

* Fix bug where invalid array length throws (close #206) * Add >=0 condition too
babel · Oct 23, 2016 · f2ec0ae · f2ec0ae
1 parent e944dcb
commit f2ec0ae
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/babel-plugin-minify-type-constructors/__tests__/type-constructors-test.js b/packages/babel-plugin-minify-type-constructors/__tests__/type-constructors-test.js
@@ -229,4 +229,17 @@ describe("type-constructors-plugin", () => {
     `);
     expect(transform(source)).toBe(expected);
   });
+
+  // https://github.com/babel/babili/issues/206
+  it("should handle floating point numbers in Array()", () => {
+    const source = unpad(`
+      new Array(-0.01);
+      new Array(-1);
+    `);
+    const expected = unpad(`
+      Array(-0.01);
+      Array(-1);
+    `);
+    expect(transform(source)).toBe(expected);
+  });
 });
diff --git a/packages/babel-plugin-minify-type-constructors/src/index.js b/packages/babel-plugin-minify-type-constructors/src/index.js
@@ -16,7 +16,7 @@ function replaceArray(t, path) {
 
       if (result.confident) {
         if (typeof result.value === "number") {
-          if (result.value <= 6) {
+          if (result.value >= 0 && result.value <= 6 && result.value % 1 === 0) {
             // "Array(7)" is shorter than "[,,,,,,,]"
             path.replaceWith(t.arrayExpression(Array(result.value).fill(null)));
           } else {