Remove old Mangle renamer #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Remove unused renamer + #106
boopathi
force-pushed
the
mangle-renamer-old
branch
from
5452f9d
to
67dbd8c
Compare
|
I don't particularly like leaving comments in the source - maybe we should just remove it then? |
|
Agreed, it's all versioned so let's just remove. |
|
The renamer is removed. The part that is turned to comments is the method "updateReferences" which is a TODO for the current renamer. Shall I remove this ? Split as 2 commits so as to be able to revert incase (before the PR is merged) |
hzoo
added
the
Tag: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.