Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rename #654

Merged
merged 2 commits into from
Aug 11, 2017
Merged

The rename #654

merged 2 commits into from
Aug 11, 2017

Conversation

boopathi
Copy link
Member

HERE WE GO

#124

@boopathi boopathi added Tag: Breaking Change Pull Request breaks the API Tag: New Feature Pull Request adding a new feature labels Aug 11, 2017
@nicolo-ribaudo
Copy link
Member

Should it be Babel Minify, BabelMinify or Babel-Minify?

@hzoo
Copy link
Member

hzoo commented Aug 11, 2017

babel-minify like babel-loader/babel-eslint, etc?

@@ -2,8 +2,8 @@

### Setup
```sh
$ git clone https://github.com/babel/babili
$ cd babili
$ git clone https://github.com/babel/minify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be git clone https://github.com/babel/minify babel-minify? and need to change below too

$ git clone https://github.com/babel/babili
$ cd babili
$ git clone https://github.com/babel/minify
$ cd minify
$ npm install
$ npm run bootstrap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: this should be npm run bootstrap which also runs yarn beforehand? don't need npm install since we are using yarn

| [`babel-plugin-transform-inline-environment-variables`](/packages/babel-plugin-transform-inline-environment-variables) | [![npm](https://img.shields.io/npm/v/babel-plugin-transform-inline-environment-variables.svg?maxAge=86400)](https://www.npmjs.com/package/babel-plugin-transform-inline-environment-variables) | [![Dependency Status](https://david-dm.org/babel/minify.svg?path=packages/babel-plugin-transform-inline-environment-variables)](https://david-dm.org/babel/minify?path=packages/babel-plugin-transform-inline-environment-variables) |
| [`babel-plugin-transform-node-env-inline`](/packages/babel-plugin-transform-node-env-inline) | [![npm](https://img.shields.io/npm/v/babel-plugin-transform-node-env-inline.svg?maxAge=86400)](https://www.npmjs.com/package/babel-plugin-transform-node-env-inline) | [![Dependency Status](https://david-dm.org/babel/minify.svg?path=packages/babel-plugin-transform-node-env-inline)](https://david-dm.org/babel/minify?path=packages/babel-plugin-transform-node-env-inline) |
| [`babel-plugin-transform-remove-console`](/packages/babel-plugin-transform-remove-console) | [![npm](https://img.shields.io/npm/v/babel-plugin-transform-remove-console.svg?maxAge=86400)](https://www.npmjs.com/package/babel-plugin-transform-remove-console) | [![Dependency Status](https://david-dm.org/babel/minify.svg?path=packages/babel-plugin-transform-remove-console)](https://david-dm.org/babel/minify?path=packages/babel-plugin-transform-remove-console) |
| [`babel-plugin-transform-remove-debugger`](/packages/babel-plugin-transform-remove-debugger) | [![npm](https://img.shields.io/npm/v/babel-plugin-transform-remove-debugger.svg?maxAge=86400)](https://www.npmjs.com/package/babel-plugin-transform-remove-debugger) | [![Dependency Status](https://david-dm.org/babel/minify.svg?path=packages/babel-plugin-transform-remove-debugger)](https://david-dm.org/babel/minify?path=packages/babel-plugin-transform-remove-debugger) |

## Benchmarks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can change the benchmark names below too

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use babel-minify instead of BabelMinify but we can change it later, feel free to merge now and do another pr

@vigneshshanmugam
Copy link
Member

The hooks are not working now.. Need to fix it

@boopathi
Copy link
Member Author

Will fix build after merge. And make the changes in docs after this merge.

@boopathi boopathi merged commit 313fa13 into master Aug 11, 2017
@boopathi boopathi deleted the the-rename branch August 11, 2017 16:18
@probins
Copy link
Contributor

probins commented Aug 14, 2017

the README is now out of sync with npm. Both npm install babel-minify and npm install babel-preset-minify install old packages.

I assume the plan is for a new release to replace the old entries on npmjs, but until then this README is more than a little confusing. Perhaps add a temporary note stating that they can't be installed until the new package has been published on npm?

@boopathi
Copy link
Member Author

Will release the new package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Breaking Change Pull Request breaks the API Tag: New Feature Pull Request adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants