Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel-minify-standalone #679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Daniel15
Copy link
Member

Similar to #6029, except for babel-minify. Moves babili-standalone from the repo (https://github.com/babel/babel-standalone) into this repo, and renames it to babel-minify-standalone.

@Daniel15 Daniel15 requested a review from boopathi August 26, 2017 21:25
"updated": "lerna updated",
"watch": "gulp watch"
},
"devDependencies": {
"babel-core": "^6.25.0",
"babel-core": "^7.0.0-alpha.19",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an important/required change for including babel-minify-standalone ?

If so, then all the plugin and preset tests will run on babel7 instead of babel6, and almost everyone using this minifier would be using it with babel6.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some build errors with 6.x. I can try again and see if I can get it working. I think it was because the latest babel-standalone versions reference babel-core 7.x.

Is there a branch of babel-minify for Babel 7.x builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a open PR for babel 7 upgrade here #487

@Daniel15 Daniel15 added the WIP Pull Request is currently Work In Progress label Aug 26, 2017
@@ -0,0 +1,42 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file extension is missing l for html.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's consistent with babel-standalone: https://github.com/babel/babel/blob/7.0/packages/babel-standalone/examples/example.htm

Should I change both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought this extension was dead long before. Its totally up to you :)

@Daniel15
Copy link
Member Author

Thanks for the info @vigneshshanmugam! I might wait for #487 to be merged first.

@boopathi
Copy link
Member

@Daniel15 #487 is merged now.

@Daniel15
Copy link
Member Author

Daniel15 commented Mar 1, 2018

Thanks! I won't have time to look into this for a while though. Would you like to try rebasing it and see if these changes still work?

@boopathi
Copy link
Member

boopathi commented Mar 1, 2018

Sure. I'll rebase it.

@boopathi
Copy link
Member

boopathi commented Mar 1, 2018

I hit a wall -

The registerBabelStandaloneTask is moved from babel-standalone repo to here - https://github.com/babel/babel/blob/master/scripts/gulp-tasks.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Pull Request is currently Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants