-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add babel-minify-standalone #679
base: master
Are you sure you want to change the base?
Conversation
"updated": "lerna updated", | ||
"watch": "gulp watch" | ||
}, | ||
"devDependencies": { | ||
"babel-core": "^6.25.0", | ||
"babel-core": "^7.0.0-alpha.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an important/required change for including babel-minify-standalone ?
If so, then all the plugin and preset tests will run on babel7 instead of babel6, and almost everyone using this minifier would be using it with babel6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some build errors with 6.x. I can try again and see if I can get it working. I think it was because the latest babel-standalone
versions reference babel-core 7.x.
Is there a branch of babel-minify for Babel 7.x builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a open PR for babel 7 upgrade here #487
@@ -0,0 +1,42 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file extension is missing l
for html
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's consistent with babel-standalone: https://github.com/babel/babel/blob/7.0/packages/babel-standalone/examples/example.htm
Should I change both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I thought this extension was dead long before. Its totally up to you :)
Thanks for the info @vigneshshanmugam! I might wait for #487 to be merged first. |
Thanks! I won't have time to look into this for a while though. Would you like to try rebasing it and see if these changes still work? |
Sure. I'll rebase it. |
I hit a wall - The |
Similar to #6029, except for babel-minify. Moves babili-standalone from the repo (https://github.com/babel/babel-standalone) into this repo, and renames it to
babel-minify-standalone
.