Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #862 #863

Merged
merged 3 commits into from
May 22, 2018
Merged

Fix issue #862 #863

merged 3 commits into from
May 22, 2018

Conversation

egasato
Copy link
Contributor

@egasato egasato commented May 22, 2018

The following changes were applied:

  • Added a condition where the property "file" is checked. If it
    doesn't exist it is copied from the original source file.

P.S: I just saw that the indentation of the closing brace is wrong (Vim's fault).

Fix issue #862
03a8b66 
The following changes were applied:

  - Added a condition where the property "file" is checked. If it
    doesn't exist it is copied from the original source file.
@egasato egasato requested a review from boopathi as a code owner May 22, 2018 12:56
boopathi
boopathi approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@boopathi boopathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint errors, You can fix it by running yarn fix

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label May 22, 2018
@egasato
Copy link
Contributor Author

egasato commented May 22, 2018

I'm sorry but I'm new to the Pull Request world. Is there a way to update the code so that Travis CI doesn't fail? The log says it's because of the indentation I previously mentioned.

@boopathi boopathi merged commit 2ec8ff7 into babel:master May 22, 2018
@boopathi
Copy link
Member

boopathi commented May 22, 2018 •
edited
Loading

Thanks!

@egasato egasato deleted the bugfix/gulp-babel-minify-862 branch May 22, 2018 13:38
@boopathi boopathi mentioned this pull request May 22, 2018
Closed
This was referenced Sep 25, 2018
Closed
Closed
Closed
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boopathi boopathi boopathi approved these changes

Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egasato @boopathi