Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decorators, transform-class-properties from stage-1 to stage-2 preset docs #883

Merged
merged 3 commits into from
Aug 5, 2016

Conversation

kevinSuttle
Copy link
Contributor

See: babel/babel#3613

TL; DR:

TC39 advanced decorators to stage 2, w/ crucial open questions re:
function, param, & property decorators needing good answers for
progress.

See: babel/babel#3613

TL; DR:
> TC39 advanced decorators to stage 2, w/ crucial open questions re:
> function, param, & property decorators needing good answers for
> progress.
- @BrendanEich
@@ -9,6 +9,7 @@ package: babel-preset-stage-2
This preset includes the following plugins:

- [transform-object-rest-spread](/docs/plugins/transform-object-rest-spread)
- [transform-decorators](/docs/plugins/transform-decorators)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep the message from before since the transform still isn't updated

I added https://github.com/babel/babel/pull/3626/files as a warning for the default one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the message should now be in stage 2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the plugin implementation didn't change so we should keep the message (although yes the spec changed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Should it still be formatted as strikethrough?

@kevinSuttle
Copy link
Contributor Author

Will do!

@kevinSuttle kevinSuttle changed the title Swap decorators from stage-1 to stage-2 preset docs Move decorators, transform-class-properties from stage-1 to stage-2 preset docs Aug 5, 2016
@hzoo hzoo merged commit dfc2aa0 into babel:master Aug 5, 2016
@hzoo
Copy link
Member

hzoo commented Aug 5, 2016

Great

@kevinSuttle
Copy link
Contributor Author

Thanks!

@kevinSuttle kevinSuttle deleted the stage-2-docs branch August 5, 2016 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants