Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extra codec support and minor improvements #4

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Jan 3, 2023

Fixes #3

This PR adds support for extra codec formats, thus allows to support chains imposing non-standard codec formats such as Injective and EVMOS. This is done by upgrading the dependency in IBC relayer, which adds support of extra codec in cosmos/relayer#1048

In addition, this PR adds documentations, scripts and example configs to ease the deployment.

Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additions of this PR mostly involve some helper scripts or configs. Do you think that those have a place in this repository? For example:

  • examples/: Do we need all of those different json files?
  • The scripts that are added are just wrappers of a single command.

I'm ok though with those being added to the repo as this is a helper repository but just wanted to raise this.

@SebastianElvis
Copy link
Member Author

The additions of this PR mostly involve some helper scripts or configs. Do you think that those have a place in this repository?

I feel it would simplify our work on deploying the Babylon relayer a bit.

The configs are identical from those in our current relayer. This repo might be the best place to hold these configs in case if
we terminate the relayer EC2 instance in the future or accidentally.

The scripts are adapted from the CLI commands I used for running relayers of the demo. It might be useful for testing and demo purposes.

  • examples/: Do we need all of those different json files?

Although the json files will eventually be a part of config.yaml, I feel it's still good to add them there since one might want to try command babylon-relayer chains add.

  • The scripts that are added are just wrappers of a single command.

Yeah agree. Maybe when we start dockerising the Babylon relayer, we can combine these scripts into a single wrapper script or merge them to the Dockerfile.

@SebastianElvis SebastianElvis merged commit 96668d7 into main Jan 4, 2023
@SebastianElvis SebastianElvis deleted the injective-support branch February 3, 2023 10:18
SebastianElvis added a commit that referenced this pull request Jan 24, 2024
SebastianElvis added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the latest commit of the Go relayer as dependency
2 participants