Remove the Equatable requirement on components. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/size-cache
branch
from
c3fe47d to
26c30bc
Compare
sergdort
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notion of component equation is practically meaningless, since interactive components generally involve non-equatable properties.
It might also be confusing if we introduce a notion of layout equivalence to facilitate size caching by default. Note that reappropriating
Equatablefor layout equivalence is inappropriate, as we would be violating theEquatablecontract regarding substitutability.Changes
Remove the
Equatablerequirement fromRenderable.The diff applier now rebinds visible cells/views unconditionally. This is practically what's happening when using Bento with BentoKit, which architecturally encourages users to simply recreate a new instance of reference type components that never equates each other by pointer equality (the default
Renderable.==implementation).Document the formal Bento component contract. (ComponentContract.md)