allow dynamic full expansion behaviour #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSMyself
previously approved these changes
May 2, 2019
inamiy
suggested changes
May 2, 2019
There was a problem hiding this comment.
@ilyapuchka
I find the demo app broken when un-commenting var fullExpansionBehaviour.
Can you check?
|
@inamiy the flag in configuration to allow partial state should be false in this case as the height of the drawer will be the same for both states and it's not currently handled properly, but I think it's a separate issue 🤷♂ |
inamiy
suggested changes
May 3, 2019
Co-Authored-By: ilyapuchka <ilyapuchka@gmail.com>
inamiy
approved these changes
May 3, 2019
andersio
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds, in addition to static configuration, ability to change the full expansion behaviour dynamically via
DrawerPresentableprotocol, similarly to partially expanded behaviour