Fixed an issue of content taps being cancelled by the drawer tap recognisers. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/tap-interference-fix
branch
2 times, most recently
from
0da91e5
to
f276167
Compare
andersio
force-pushed
the
anders/tap-interference-fix
branch
3 times, most recently
from
3bfff69
to
b411be3
Compare
andersio
force-pushed
the
anders/tap-interference-fix
branch
2 times, most recently
from
bda2f00
to
bffcdcb
Compare
andersio
force-pushed
the
anders/tap-interference-fix
branch
from
bffcdcb
to
45b6712
Compare
wltrup
previously approved these changes
Apr 6, 2018
| return false | ||
| } else { | ||
| return true | ||
| } |
There was a problem hiding this comment.
return (subview is UIControl).isFalse ?
diegopetrucci
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tap recognisers installed by DrawerKit, if enabled, would cancel the delivery of touch events to the content view by default. This causes problems with at least
UITableView, whose selection mechanism relies on these events.This branch also enables controls within the drawer content to be interactive, even if the drawer is not fully expanded.