Pull to Dismiss UIScrollView drawers. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/pull-to-dismiss
branch
from
24eaec3
to
e88a041
Compare
andersio
changed the title
andersio
force-pushed
the
anders/pull-to-dismiss
branch
3 times, most recently
from
40b22bf
to
4346e03
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
4 times, most recently
from
675c27e
to
13831b8
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
2 times, most recently
from
f9179f3
to
19a4253
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
8 times, most recently
from
fc820ea
to
5c1026b
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
from
5c1026b
to
3054304
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
2 times, most recently
from
820f0c7
to
1df08ee
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
3 times, most recently
from
8a5803b
to
2f62621
Compare
andersio
force-pushed
the
anders/pull-to-dismiss
branch
from
2f62621
to
798fb4c
Compare
wltrup
previously approved these changes
Apr 11, 2018
| @@ -54,6 +86,10 @@ extension PresentationController { | |||
| } | |||
|
|
|||
| override func presentationTransitionWillBegin() { | |||
| // NOTE: `targetDrawerState.didSet` is not invoked within the | |||
There was a problem hiding this comment.
That's supposed to be common knowledge (that the property observers don't get triggered inside initialisers) so I don't think we need the comment here.
| /// obscure `UINavigationBar` Large Title mechanism. | ||
| /// | ||
| /// - note: The drawer presentation controller does not retain the view. | ||
| var scrollViewForPullToDismiss: UIScrollView? { get set } |
sergdort
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawer Content VCs may enable pull to dismiss simply by setting
scrollViewForPullToDismisson the drawer presentation controller. Supports iOS 11 Large Title.