Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New corner option: alwaysShowBelowStatusBar. #61

Merged
merged 3 commits into from
Apr 12, 2018

Conversation

andersio
Copy link
Contributor

@andersio andersio commented Apr 7, 2018

corner

sergdort
sergdort previously approved these changes Apr 12, 2018
Copy link
Contributor

@wltrup wltrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a stickler for correct grammar...

@@ -33,6 +33,18 @@ public struct DrawerConfiguration {
}
}

public enum CornerAnimationOption {
/// The corners would be at its maximum radius when the drawer is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The corners would be at its their maximum radius when the drawer is..."

/// direction.
case maximumAtPartialY

/// The corners would be always shown below the status bar at its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... at their...

@andersio andersio merged commit b563734 into master Apr 12, 2018
@andersio andersio deleted the anders/corner-animation-option branch April 12, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants