[IOSP-543] Fix MergeBot deployment #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Ben-Henshall
approved these changes
Jan 23, 2020
AliSoftware
commented
Jan 23, 2020
ilyapuchka
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
One of the newly introduced env var was supposed to be optional, but was implemented as required, which made the last attempt at deploying the MergeBot fail (†)
Also another env var was providing a default value… but implemented as required nonetheless
(†) We could just have added the env var to the manifest but making this one optional feels more logical, and will avoid failing for the same reason when Android decides to deploy their instance to latest tag too)
How
Made the 2 env vars optional, and not
throwsanymore, allowing the default value for it to be usefulTook the occasion to improve env vars doc