-
Notifications
You must be signed in to change notification settings - Fork 28
module-info.class prevents signed builds from being generated, throws errors when building debug builds. #5
Comments
An update: I've submitted the build logs to New Relic to see if this something they could also fix on their side. Point still stands though that JPMS is a Java 9+ feature. |
Having looked through the jar the CI build generates there is no Indeed the CI system uses Java 8. I suspect it must be one of the dependencies the library uses, most likely bouncy castle which is necessary for processing the certificates. See bcgit/bc-java#477 Looks as though 1.62 should fix this when it is released. For the time being I can look to rolling back to 1.60. |
Yes, after looking through the logs and sharing them with New Relic, it looks like BouncyCastle is generating the |
@mattmook - appreciate how responsive you've been on this and my other issue. I've been talking with the folks at New Relic about this issue, because it's their SDK that's breaking our release builds. Wanted to let you know that this is still an issue: Generated
Obviously, it's on New Relic to fix this particular bug in their SDK, but wanted to ask: on your side, is there a way to solve for this? |
@mattmook Update: New Relic released the Android Agent 5.24.0 today which supposedly had fixed this issue, but I'm getting the same error. |
hi @elliottj-accolade I realise it's been a long time but I'd forgotten to chase up and see whether you ever got this resolved. I've been trying to reproduce this in the sample app to see if recent changes would help resolve this but so far haven't got it to fail! |
At the time of the report I hadn't realised that bouncycastle had started releasing (from v1.63) a |
@mattmook Please suggest on how to proceed. This is blocking me use the library. PFA the console outcome on building the project |
Does adding the following kind of entry help?
|
Closing issue as from my own more recent tests this seems to no longer be an issue. |
Here's my configuration:
Admittedly, this issue could stem from a few different sources (R8, New Relic, and this lib), but I only noticed this issue when New Relic choked on it. Verified that it was only after adding the
certificate-transparency-android
lib that the error was thrown, so thought I'd start here.Supposedly, the JPMS error was fixed in 3.4.0-beta, but it also depends on whether the library itself supports JPMS and/or was built with R8. Moreover, I did some research and found that
module-info.class
is only supported / used in Java 9+, which Android does not currently support.Is this something that you could fix on your side?
The text was updated successfully, but these errors were encountered: