Eots refactor 2 #33
Merged
Eots refactor 2 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 6, 2024 09:24
SebastianElvis
approved these changes
Aug 6, 2024
Comment on lines
277
to
285
| let btc_sk = pk | ||
| .extract( | ||
| &evidence.pub_rand, | ||
| &evidence.canonical_app_hash, | ||
| &evidence.canonical_finality_sig, | ||
| &evidence.fork_app_hash, | ||
| &evidence.fork_finality_sig, | ||
| ) | ||
| .map_err(|err| ContractError::SecretKeyExtractionError(err.to_string()))?; |
There was a problem hiding this comment.
Hmm extract is probably not suitable to be a function under the public key. Why not just keep it as is?
There was a problem hiding this comment.
Was thinking the same. What about calling it extract_secret_key?
maurolacy
force-pushed
the
eots-refactor-2
branch
from
9d6666f to
f67231e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27 follow-up. Better encapsulation for types.